Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python cmdline parser for variants #180

Merged
merged 5 commits into from
Sep 25, 2024

Commits on Sep 24, 2024

  1. fix python cmdline parser for variants

    Given
    ```
    type operation = Copy of string | Mirror of string
    ```
    
    Represented as `["Copy", "arg"]` we need to parse that as JSON when given on the cmdline.
    
    Otherwise it'd do `operation[0]`, where `operation` is a string, which is not what we want.
    
    This doesn't affect usage from xapi-storage-script (which always calls it with --json),
    but it affects testing the python code by hand, because you can't supply the correct cmdline arguments
    (unless you construct an entire JSON by hand and pass it on stdin which is a bit tedious)
    
    Signed-off-by: Edwin Török <edwin.torok@cloud.com>
    edwintorok authored and Vincent-lau committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0327f71 View commit details
    Browse the repository at this point in the history
  2. CI: use setup-ocamlv3

    Vincent-lau committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    cae47be View commit details
    Browse the repository at this point in the history
  3. CI: Update ocaml-version

    Vincent-lau committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7101007 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. CI: Update setup python

    Vincent-lau committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a8d529d View commit details
    Browse the repository at this point in the history
  2. Drop python2 support

    Since we are not testing it in the CI anyway.
    Vincent-lau committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    31dac5b View commit details
    Browse the repository at this point in the history