Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checksum offload #1

Open
talex5 opened this issue Jan 2, 2016 · 0 comments
Open

Checksum offload #1

talex5 opened this issue Jan 2, 2016 · 0 comments
Labels
enhancement

Comments

@talex5
Copy link
Collaborator

talex5 commented Jan 2, 2016

Currently, we don't checksum incoming packets and we calculate the full checksum when doing NAT. This means:

  1. We may fail to detect invalid incoming packets (although hopefully NetVM will check that for us).
  2. We calculate checksums that aren't needed (packet is going internally, or the hardware could add it).
  1. Packets routed internally from one Linux VM to another might lose the flag saying the checksum is invalid.

The Mirage NETWORK interface should be extended to allow us to read and write the checksum flags so we can set things correctly.
talex5 pushed a commit that referenced this issue Jan 3, 2016
Calculate checksums even for Accept action
491dbd9 
If packet has been NAT'd then we certainly need to recalculate the checksum,
but even for direct pass-through it might have been received with an invalid
checksum due to checksum offload. For now, recalculate full checksum in all
cases.

See #1.
@talex5 talex5 mentioned this issue Sep 16, 2016
Closed
@jorgejones7711 jorgejones7711 mentioned this issue Jun 29, 2020
Closed
@talex5 talex5 mentioned this issue Dec 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@talex5