Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitosheet.sheet(dfs[0]) leads to execution error on every edit event #1249

Open
aarondr77 opened this issue Mar 8, 2024 · 1 comment
Open
Labels

Comments

@aarondr77
Copy link
Member

  1. Run this code
import pandas as pd
import mitosheet

dfs = [pd.DataFrame({'A': [1,2,3]})]
mitosheet.sheet(dfs[0])
  1. Add a column
  2. Get this execution error
  File "add_column.py", line 48, in execute
    return cls.execute_through_transpile(
  File "step_performer.py", line 156, in execute_through_transpile
    exec(final_code, exec_globals, exec_locals)
  File "<string>", line 1, in <module>
NameError: name 'dfs' is not defined
@aarondr77 aarondr77 added type: mitosheet Changes the mitosheet package effort: 2 priority: high labels Mar 8, 2024
@naterush
Copy link
Contributor

Ok -- so there's some complexity in getting this to work. Namely, we can handle this in the args update (e.g. just turning this into df -- but we also need to handle it in the transpiler as well. And then there's the code that is parameterized.

Part of me thinks args update should almost just be a step in it's own right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants