Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the beat marker behaviour to allow grid stretching #13768

Open
acolombier opened this issue Oct 14, 2024 · 0 comments
Open

Improve the beat marker behaviour to allow grid stretching #13768

acolombier opened this issue Oct 14, 2024 · 0 comments
Labels
confirmed control objects Issues and bugs specifically in regard to mixxx `ControlObjects` feature

Comments

@acolombier
Copy link
Member

acolombier commented Oct 14, 2024

Currently, beats_set_marker will only add a a new grid, leading the previous grid to have an uneven number of beats. This as to address the case with varying BPM or beat/half-beat track.

Going forward, we add a new CO to allow setting a new marker, which stretches the previous grid and keep complete (that is, contain an integer of beats)

A nice to have would be to make beats_set_marker configurable to allow its behaviour to optionally copy beats_stretch's behaviour. This would allow mappings to prioritise the use of beats_set_marker, but still allow user to change the default behaviour, in case they don't use tracks with varying BPM or beat phase.

Originally discussed in #13330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed control objects Issues and bugs specifically in regard to mixxx `ControlObjects` feature
Projects
None yet
Development

No branches or pull requests

1 participant