-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto DJ: Synchronizing queue's top item and next deck #8956
Comments
Commented by: daschuer
Cool, thank you very much. I think the main issue is solved, if loading a track to an Auto DJ enabled deck is also added to the topmost AutoDJ queue position. A second aspect is that if the just loaded track was originally in the Auto DJ queue, it should be removed from the original position to avoid to play this track again later. IMHO there is no need to have this behaviour configurable, because it sound so natural that everyone van make use of it. We already have a signal slot for it, where the new code can be hooked in: The queue can be accessed via m_pAutoDJTableModel Do you have already a build environment? |
Commented by: asfan.shirim Here is the detailed behavior I have in mind.
The above behavior is set so the top AutoDJ queue track will forever be next one to be played when AutoDJ is enabled. This gives very natural and intuitive attributes to the AutoDJ feature. The exception in 3B is in place so we do not add tracks to the queue by mistake. E.g., double-clicking a track to play it next, but then deciding to play something different and we double-click another track to set it as top. Without this exception the first track we double-clicked would still be in the queue at the second position. |
Commented by: daschuer 3B might be hard to understand, because we have to track, what was the reason for track #1 to be on top. This might be forgotten by the user after a while so the behaviour may feel like a bug. The current implementation for this case is not too bad:
Currently, if you like to save the loaded track to Auto DJ you can drag it to the AUTO DJ cue before you double click on the new track. This is kind of odd, because you may loose the context of your new track. I think it depends on the original track itself if it is still relevant to be played next or not.
The proposed way of implementation in #1 seems to be the easiest to implement. For 1. you just need to "prevent" to move a track to #1 and load it instead, which moves the track to #1 afterwards and the cued track back to #2. We need to be aware that this way a ready cued track will be kicked out of the deck. Can this happen accidentally? |
Commented by: asfan.shirim Is there a working Visual Studio project I can use? I got a working build, but I'm hoping I can properly use an IDE for windows development. |
Commented by: daschuer I am afraid not. I am on Linux using Eclipse but maybe someone else can give hints for VS. https://www.mixxx.org/wiki/doku.php/developer_tools Contains links to setup eclipse or qtcreator |
Commented by: sblaisot I'm on windows and use atom. |
Reported by: asfan.shirim
Date: 2017-10-26T14:40:47Z
Status: Confirmed
Importance: Wishlist
Launchpad Issue: lp1727747
Tags: autodj
This is a feature request, although for me is fixing an unwanted AutoDJ behavior.
Continuing https://www.mixxx.org/forums/viewtopic.php?f=1&t=9409
I wish to have a feature that synchronizes the AutoDJ's top queue item with the next available deck, when AutoDJ is enabled.
What currently happens in Mixxx ?
I find this terribly confusing. It already happened several times that I changed the top track, but forgot to load it to the deck.
I think there should be an option to enable synchronizing the top queue slot with the next available deck, so when I change the one the other changes as well.
Additionally, if I double-click a track to load to the deck, it will ALSO be added to the top slot of the AutoDJ queue.
If I double-click on a track that is already in the AutoDJ list, it will moved to the top and loaded onto the deck.
I think my suggested feature is very intuitive and it is what I expected as the default behavior of AutoDJ.
The text was updated successfully, but these errors were encountered: