Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding method to delete account #17

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

abuzzell
Copy link

I've added methods for deleting a user account from firebase using the adminsdk.

@miyataka
Copy link
Owner

@abuzzell
Thank you for your contribution!
I'll review in 2 or 3 days. Please wait.

@miyataka miyataka self-requested a review November 25, 2021 02:56
@miyataka miyataka added enhancement New feature or request good first issue Good for newcomers labels Nov 25, 2021
Copy link
Owner

@miyataka miyataka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abuzzell
Thank you so much for your contribution!!
Please check some review comments.
If you have any questions, please feel free to ask a question.

lib/firebase_token_auth/client.rb Outdated Show resolved Hide resolved
@@ -1,3 +1,3 @@
module FirebaseTokenAuth
VERSION = '1.3.0'.freeze
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please exclude this change.
I'll change version number by myself after add some test code.

@miyataka
Copy link
Owner

miyataka commented Dec 2, 2021

@abuzzell
Thank you for your update. 2ee8afb (#17)

And would you please respond to this comment?
#17 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants