This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
[WIP] Add validation for default ingresscontroller load balancer #16
+174
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjlshen
force-pushed
the
main
branch
4 times, most recently
from
1e3e007
to
55cc394
Compare
Signed-off-by: Michael Shen <mshen@redhat.com>
mjlshen
force-pushed
the
main
branch
18 times, most recently
from
6496dd5
to
60897a7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would close #8
This is the high-level idea, but it's a bit rough as the default one starts as a CLB, but can be swapped out for an NLB
Also some duplicated code validating security group rules