Implement standardization of static features #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR makes sure static features are standardized in the same way as state and forcing. As standard features are loaded directly in the model, they are not handled by the standardization in WeatherDataset. This makes sure that they are still standardized.
The standardization is achieved by introducing an optional argument
standardize
in the get_dataarray Datastore method, optionally returning the dataarray standardized. The motivation is to leave as much of the control of the data loading to the Datastore class. It is also good to have this re-usable approach, as the same standardization method can then later be used for loading static fields in the boundary region.In the future also other types of rescaling (e.g. to [0,1]) might be desirable for static features as well as making standardization optional. However, as that similarly applies to state and forcing that is a separate issue.
Issue Link
This closes #95.
Type of change
Checklist before requesting a review
pull
with--rebase
option if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee