Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Separate deploy and test #140

Open
tischi opened this issue Apr 26, 2023 · 3 comments
Open

CI: Separate deploy and test #140

tischi opened this issue Apr 26, 2023 · 3 comments

Comments

@tischi
Copy link
Collaborator

tischi commented Apr 26, 2023

@constantinpape

Here we should also think about refactoring the CI.

Here, however, I think we would need also the SNAPSHOT versions to be deployed to maven, otherwise I think we will run into such issues: https://github.com/mobie/mobie-viewer-fiji/actions/runs/4806700915, where the build on develop failed because it did not have the most recent mobie-io version...

Thus maybe it is OK as it currently is, what do you think?

@constantinpape
Copy link
Collaborator

If we are fine with running the deployment on pushing to develop as well (for pushing the SNAPSHOTS) then I don't really think we need to change anything in the current yaml, see https://github.com/mobie/mobie-io/blob/main/.github/workflows/build.yml#L7.

But I think we should add another test.yaml that only runs the tests for pull requests onto develop, so that we know beforehand if those break anything. For this you should be able to more or less copy what we did for mobie-fiji: https://github.com/mobie/mobie-viewer-fiji/blob/develop/.github/workflows/test.yml

@KateMoreva
Copy link
Collaborator

KateMoreva commented Jul 12, 2023

Simple realisation is here #145

test-> will work for pull_request to main or develop
run mvn test (works)

build-snapshot -> will work only for pull_request to develop or push to develop with tag *.[0-9]-SNAPSHOT
run mvn test + .github/build.sh (seems to work)

deploy-main-> will work only for push to develop or main with tag [0-9].[0-9].[0-9]
run mvn test + .github/build.sh (not tested yet)

@tischi
Copy link
Collaborator Author

tischi commented Dec 16, 2023

@imagejan may I ask your help to also check for this repo whether the CI is set up correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants