Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code generator for OCPP 2.1 #451

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add code generator for OCPP 2.1 #451

wants to merge 4 commits into from

Conversation

OrangeTux
Copy link
Contributor

@OrangeTux OrangeTux commented Jul 17, 2023

This PR introduces support for OCPP 2.1. The code in ocpp/v21 is generated by the newly
introduced code generator.

I've created this draft to gather feedback on the generated code in ocpp/v21, not on the code generator itself.
The generator requires some clean up and tests.

Unfortunately, I'm not allowed to include the JSON schemas with this PR at the moment. The OCA
distributed these files to members only. I'm in touch with the OCA to see if they allow me to include
the schemas in this project.

Fixes: #452

@OrangeTux OrangeTux changed the title Add support for OCPP 2.1 Add support for OCPP 2.1 draft 1 Jul 17, 2023
@OrangeTux OrangeTux changed the title Add support for OCPP 2.1 draft 1 Add code generator for OCPP 2.1 Jul 20, 2023
@OrangeTux OrangeTux force-pushed the 448-ocpp-21 branch 2 times, most recently from d55df35 to c5d1764 Compare July 20, 2023 13:45
This commit introduces a script that parses the JSON schemas for OCPP
2.1 and generate Python code.

Fixes: #452
@OrangeTux OrangeTux marked this pull request as ready for review July 20, 2023 14:12
@OrangeTux OrangeTux requested a review from tropxy as a code owner July 20, 2023 14:12
@OrangeTux OrangeTux requested review from klimaschkas and Jared-Newell-Mobility and removed request for Jared-Newell-Mobility July 20, 2023 14:13
@OrangeTux OrangeTux requested a review from proelke July 25, 2023 09:12
@Jared-Newell-Mobility
Copy link
Contributor

Jared-Newell-Mobility commented Nov 15, 2023

I think we should remove from the PR the calls and calls results .json for now - maybe only include the generator components and then I can read in the schemas and compare the output results, then give feed back if it comes out correctly or not?

@alexmclarty
Copy link
Contributor

It is frustrating that the OCA doesn't allow these artefacts to be in the public domain! I know this isn't the place to discuss this, so I'll not go on for too long... 😁

It's the same for the OCPP docs. They're available in PDF, not HTML, which makes creating tools that link to specific sections tricky. You have to add a reference to, for example, 5.16. Set Charging Profile.

It'd be 🆒 to get these specifications in the public domain and reduce the friction for contribution and innovation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add code generator to generate OCPP 2.1 code
3 participants