Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong data type in CostUpdatedPayload.total_cost in respect to json schema #557

Closed
AlfredoNaef opened this issue Dec 22, 2023 · 3 comments
Closed

Wrong data type in CostUpdatedPayload.total_cost in respect to json schema #557

AlfredoNaef opened this issue Dec 22, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@AlfredoNaef
Copy link

Hello,

There is a mismatch between the data type for CostUpdatedPayload.total_cost in ocpp.ocpp.v201.datatypes and the json schema for CostUpdatedRequest. Specifically, in the first is defined as integer and the json schema a number, tha usually should be a float in python. Nevertheless, this difference yields the failure of the validation of the payload and hence the message is not sent. Though, just changing the type to float in CostUpdatedPayload.total_cost might not solve the problem, because afterwards the payload validation would fails when parsing the floats as metnioned in a previous issue of mine #555.
@AlfredoNaef AlfredoNaef added the bug Something isn't working label Dec 22, 2023
@OrangeTux
Copy link
Contributor

Thanks for the report. You're right. The specification clearly states it's a decimal. And therefore, the dataclass should model the attribute total_cost as a float.

@Jared-Newell-Mobility Jared-Newell-Mobility changed the title Wrong data type in CostUpdatedPayload.total_cost repsect to json schema Wrong data type in CostUpdatedPayload.total_cost in respect to json schema Feb 5, 2024
Merged
@Jared-Newell-Mobility
Copy link
Contributor

PR created #596

Jared-Newell-Mobility added a commit that referenced this issue Feb 7, 2024
@Jared-Newell-Mobility
OCPP 2.0.1 Wrong data type in CostUpdated total_cost (#596)
c4d96d9 
see issue #557
@Jared-Newell-Mobility
Copy link
Contributor

Merged so will now close

Merged
Jared-Newell-Mobility added a commit that referenced this issue Feb 14, 2024
@Jared-Newell-Mobility
Bump to 1.0.0-rc.1 (#611)
dbfb006 
## 1.0.0-rc.1 (2024-02-14)

- [#573](#573) Introduce
Experimental Module For v2.1
- [#547](#547) Feat: Handle
recursively serializing a dataclasses as a dictionary Thanks
[@MacDue](https://github.com/MacDue)
- [#601](#601) Fix case
conversion for soc in non "State of Charge" context
- [#523](#523) The
serialisation of soc to SoC should not occur in camel case if it is
existing at the beginning of a field
- [#515](#515) Update
Readthedocs configuration
- [#602](#602) Correct v2g
serialisation/deserialisation
- [#557](#557) OCPP 2.0.1
Wrong data type in CostUpdated total_cost
- [#564](#564) Add support
For Python 3.11 and 3.12
- [#583](#583) OCPP
v1.6/v2.0.1 deprecate dataclasses from calls and call results with the
suffix 'Payload'
- [#590](#336)
snake_to_camel_case url to URL does not get converted correctly
- [#591](#591)
Camel_to_snake_case doesn't handle v2x correctly
- [#593](#593) Update tests
to use Call and CallResult without the suffix Payload
- [#435](#435) Typo in
CostUpdated Action
- [#577](#577) v2.0.1
AttributeType Enum Corrections
- [#340](#340) 2.0.1
dataclasses have a incorrect types that don't match carnality
- [#519](#519) Typo in
v201.enums.StatusInfoReasonType.invaild_schedule
- [#510](#510) v2.0.1
UnitOfMeasureType - Enums missing and update docstring to allow use for
variableCharacteristics
- [#508](#508) Exception -
OccurrenceConstraintViolationError doc string correction

## DEPRECATED ##
- [#599](#599) v1.6 Action
Enum members corrected IMPORTANT SEE UPGRADE PATH
[#599](#599)
- [#579](#579) v2.0.1 Action
enums corrected - IMPORTANT SEE UPGRADE PATH
[#579](#579)

## BREAKING ##
- [#574](#574) Remove v1.6
deprecated enum members - IMPORTANT see upgrade path
[#574](#574)
- [#498](#498) Remove
support for OCPP 2.0 - IMPORTANT SEE UPGRADE PATH
[#498](#498)
RoaringDev1203 added a commit to RoaringDev1203/Cratus-OCPP that referenced this issue Aug 27, 2024
@RoaringDev1203
OCPP 2.0.1 Wrong data type in CostUpdated total_cost (#596)
0a0eea5 
see issue mobilityhouse/ocpp#557
RoaringDev1203 added a commit to RoaringDev1203/Cratus-OCPP that referenced this issue Aug 27, 2024
@RoaringDev1203
Bump to 1.0.0-rc.1 (#611)
d3b7fe6 
## 1.0.0-rc.1 (2024-02-14)

- [#573](mobilityhouse/ocpp#573) Introduce
Experimental Module For v2.1
- [#547](mobilityhouse/ocpp#547) Feat: Handle
recursively serializing a dataclasses as a dictionary Thanks
[@MacDue](https://github.com/MacDue)
- [#601](mobilityhouse/ocpp#601) Fix case
conversion for soc in non "State of Charge" context
- [#523](mobilityhouse/ocpp#523) The
serialisation of soc to SoC should not occur in camel case if it is
existing at the beginning of a field
- [#515](mobilityhouse/ocpp#515) Update
Readthedocs configuration
- [#602](mobilityhouse/ocpp#602) Correct v2g
serialisation/deserialisation
- [#557](mobilityhouse/ocpp#557) OCPP 2.0.1
Wrong data type in CostUpdated total_cost
- [#564](mobilityhouse/ocpp#564) Add support
For Python 3.11 and 3.12
- [#583](mobilityhouse/ocpp#583) OCPP
v1.6/v2.0.1 deprecate dataclasses from calls and call results with the
suffix 'Payload'
- [#590](mobilityhouse/ocpp#336)
snake_to_camel_case url to URL does not get converted correctly
- [#591](mobilityhouse/ocpp#591)
Camel_to_snake_case doesn't handle v2x correctly
- [#593](mobilityhouse/ocpp#593) Update tests
to use Call and CallResult without the suffix Payload
- [#435](mobilityhouse/ocpp#435) Typo in
CostUpdated Action
- [#577](mobilityhouse/ocpp#577) v2.0.1
AttributeType Enum Corrections
- [#340](mobilityhouse/ocpp#340) 2.0.1
dataclasses have a incorrect types that don't match carnality
- [#519](mobilityhouse/ocpp#519) Typo in
v201.enums.StatusInfoReasonType.invaild_schedule
- [#510](mobilityhouse/ocpp#510) v2.0.1
UnitOfMeasureType - Enums missing and update docstring to allow use for
variableCharacteristics
- [#508](mobilityhouse/ocpp#508) Exception -
OccurrenceConstraintViolationError doc string correction

## DEPRECATED ##
- [#599](mobilityhouse/ocpp#599) v1.6 Action
Enum members corrected IMPORTANT SEE UPGRADE PATH
[#599](mobilityhouse/ocpp#599)
- [#579](mobilityhouse/ocpp#579) v2.0.1 Action
enums corrected - IMPORTANT SEE UPGRADE PATH
[#579](mobilityhouse/ocpp#579)

## BREAKING ##
- [#574](mobilityhouse/ocpp#574) Remove v1.6
deprecated enum members - IMPORTANT see upgrade path
[#574](mobilityhouse/ocpp#574)
- [#498](mobilityhouse/ocpp#498) Remove
support for OCPP 2.0 - IMPORTANT SEE UPGRADE PATH
[#498](mobilityhouse/ocpp#498)
ajmirsky pushed a commit to ajmirsky/ocpp that referenced this issue Nov 26, 2024
@Jared-Newell-Mobility
OCPP 2.0.1 Wrong data type in CostUpdated total_cost (mobilityhouse#596)
84f7e7e 
see issue mobilityhouse#557
ajmirsky pushed a commit to ajmirsky/ocpp that referenced this issue Nov 26, 2024
@Jared-Newell-Mobility
Bump to 1.0.0-rc.1 (mobilityhouse#611)
3dce54f 
## 1.0.0-rc.1 (2024-02-14)

- [mobilityhouse#573](mobilityhouse#573) Introduce
Experimental Module For v2.1
- [mobilityhouse#547](mobilityhouse#547) Feat: Handle
recursively serializing a dataclasses as a dictionary Thanks
[@MacDue](https://github.com/MacDue)
- [mobilityhouse#601](mobilityhouse#601) Fix case
conversion for soc in non "State of Charge" context
- [mobilityhouse#523](mobilityhouse#523) The
serialisation of soc to SoC should not occur in camel case if it is
existing at the beginning of a field
- [mobilityhouse#515](mobilityhouse#515) Update
Readthedocs configuration
- [mobilityhouse#602](mobilityhouse#602) Correct v2g
serialisation/deserialisation
- [mobilityhouse#557](mobilityhouse#557) OCPP 2.0.1
Wrong data type in CostUpdated total_cost
- [mobilityhouse#564](mobilityhouse#564) Add support
For Python 3.11 and 3.12
- [mobilityhouse#583](mobilityhouse#583) OCPP
v1.6/v2.0.1 deprecate dataclasses from calls and call results with the
suffix 'Payload'
- [mobilityhouse#590](mobilityhouse#336)
snake_to_camel_case url to URL does not get converted correctly
- [mobilityhouse#591](mobilityhouse#591)
Camel_to_snake_case doesn't handle v2x correctly
- [mobilityhouse#593](mobilityhouse#593) Update tests
to use Call and CallResult without the suffix Payload
- [mobilityhouse#435](mobilityhouse#435) Typo in
CostUpdated Action
- [mobilityhouse#577](mobilityhouse#577) v2.0.1
AttributeType Enum Corrections
- [mobilityhouse#340](mobilityhouse#340) 2.0.1
dataclasses have a incorrect types that don't match carnality
- [mobilityhouse#519](mobilityhouse#519) Typo in
v201.enums.StatusInfoReasonType.invaild_schedule
- [mobilityhouse#510](mobilityhouse#510) v2.0.1
UnitOfMeasureType - Enums missing and update docstring to allow use for
variableCharacteristics
- [mobilityhouse#508](mobilityhouse#508) Exception -
OccurrenceConstraintViolationError doc string correction

## DEPRECATED ##
- [mobilityhouse#599](mobilityhouse#599) v1.6 Action
Enum members corrected IMPORTANT SEE UPGRADE PATH
[mobilityhouse#599](mobilityhouse#599)
- [mobilityhouse#579](mobilityhouse#579) v2.0.1 Action
enums corrected - IMPORTANT SEE UPGRADE PATH
[mobilityhouse#579](mobilityhouse#579)

## BREAKING ##
- [mobilityhouse#574](mobilityhouse#574) Remove v1.6
deprecated enum members - IMPORTANT see upgrade path
[mobilityhouse#574](mobilityhouse#574)
- [mobilityhouse#498](mobilityhouse#498) Remove
support for OCPP 2.0 - IMPORTANT SEE UPGRADE PATH
[mobilityhouse#498](mobilityhouse#498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
3 participants
@OrangeTux @AlfredoNaef @Jared-Newell-Mobility