Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an html beautifier library instead of including indenting and line feed in code #217

Open
pascalchevrel opened this issue Mar 28, 2014 · 2 comments
Open

Use an html beautifier library instead of including indenting and line feed in code #217

pascalchevrel opened this issue Mar 28, 2014 · 2 comments
Assignees
@pascalchevrel

Comments

@pascalchevrel
Copy link
Member

We can avoid inserting tons of spaces and line breaks in the code to align out html output by using an indentation library and let it indend the resulting output of the whole template. it will make the php easier to read and the html better indented in general.
@pascalchevrel pascalchevrel self-assigned this Mar 28, 2014
@flodolo
Copy link
Collaborator

flodolo commented Mar 28, 2014

I definitely agree (for all our projects). TBH I wasn't aware of such tools.

pascalchevrel added a commit that referenced this issue Mar 28, 2014
@pascalchevrel
Issue #217: Indent html in our html output
bd5f96b 
* add a dependency in composer.json to "gajus/dindent"
* remove manual indent and line breaks in Utils::printSimpleTable() used in the accesskey view as an example
* fixed a not closed <div> in the process
pascalchevrel added a commit that referenced this issue Mar 28, 2014
@pascalchevrel
Issue #217: Indent html in our html output
7e9d839 
* add a dependency in composer.json to "gajus/dindent"
* remove manual indent and line breaks in Utils::printSimpleTable() used in the accesskey view as an example
* fixed a not closed <div> in the process
pascalchevrel added a commit that referenced this issue Mar 29, 2014
@pascalchevrel
Merge pull request #218 from mozfr/issue-217-indent-generated-html
a55b515 
Issue #217: Indent html in our html output
@pascalchevrel pascalchevrel reopened this May 15, 2014
@pascalchevrel
Copy link
Member Author

reopening, the library we use is a memory hog with long pages :( Sometimes it goes beyong the memory limits in php.ini and we get a 500 error, I am going to remove it for now until we find a better library or that library gets fixed

pascalchevrel added a commit that referenced this issue May 15, 2014
@pascalchevrel
Merge pull request #250 from pascalchevrel/master
ae3497b 
issue #217 : backout use of Dindent library has it has memory problems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pascalchevrel pascalchevrel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pascalchevrel @flodolo