Skip to content
This repository has been archived by the owner on Dec 1, 2017. It is now read-only.

Client code needs to be refactored #379

Open
gideonthomas opened this issue Oct 2, 2014 · 2 comments
Open

Client code needs to be refactored #379

gideonthomas opened this issue Oct 2, 2014 · 2 comments
Assignees
Milestone

Comments

@gideonthomas
Copy link
Contributor

Even with the plethora of comments and documentation, the client-side code is becoming really hard to follow. The flow of logic should be more explicit and clear. Files like message-handler.js and index.js have too much clutter in them and need to be cleaned up and simplified.
This is not a crucial issue but it needs to get done sometime.

@humphd
Copy link
Contributor

humphd commented Oct 4, 2014

I think we should aim for a parallel structure to what's evolved for the server:

  • index.js - (ike client-manager.js) manages instance/lifetime of client.js, manages events for caller
  • client.js - manages ws and holds state, holds ref to sync-protocol-handler
  • sync-protocol-handler.js - holds ref to client, stateless protocol steps

@alicoding
Copy link
Collaborator

I've extended this milestone till end of this week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants