Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

Bypass makedrive if WebSocket is undefined #396

Closed
thisandagain opened this issue Oct 22, 2014 · 6 comments
Closed

Bypass makedrive if WebSocket is undefined #396

thisandagain opened this issue Oct 22, 2014 · 6 comments
Assignees
@k88hudson
Labels
critical
Milestone
Kenya

Comments

@thisandagain
Copy link
Contributor

Switching to offline mode if typeof global.WebSocket === 'undefined' might be enough. This is currently blocking Android support via beaker. See: mozilla/makedrive#448
@thisandagain thisandagain added this to the Mozfest milestone Oct 22, 2014
@k88hudson
Copy link
Contributor

@thisandagain I'm assuming you mean global.WebSocket right

@thisandagain
Copy link
Contributor Author

O_o yes. Updated

@k88hudson
Copy link
Contributor

Ok so I looked into this, looks like requiring MakeDrive at all will throw. Unfortunately since offline mode still relies on MakeDrive for local filesystem stuff, we'll either have to:

  • disable all makedrive functionality if no websockets
  • land a patch upstream to not throw

@k88hudson
Copy link
Contributor

mozilla/makedrive#449 and an early return on our end should solve this issue for us temporarily

@k88hudson
Copy link
Contributor

waiting for a response on that PR

@gideonthomas gideonthomas mentioned this issue Oct 22, 2014
Merged
@thisandagain thisandagain modified the milestones: Mozfest, Kenya Oct 28, 2014
@k88hudson
Copy link
Contributor

This is resolved in that it is no longer app-breaking.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@k88hudson k88hudson

Labels
critical
Projects
None yet
Milestone
Kenya
Development

No branches or pull requests
2 participants
@thisandagain @k88hudson