Skip to content

Commit

Permalink
vo_gpu_next: remove colospace overrides
Browse files Browse the repository at this point in the history
Hacks like that has no place here, mp_image should be tagged correctly,
across the player, gpu-next is not special.
  • Loading branch information
kasper93 committed Nov 20, 2024
1 parent 4e5cc9c commit ef6052c
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions video/out/vo_gpu_next.c
Original file line number Diff line number Diff line change
Expand Up @@ -625,23 +625,6 @@ static bool map_frame(pl_gpu gpu, pl_tex *tex, const struct pl_source_frame *src
.user_data = mpi,
};

// mp_image, like AVFrame, likes communicating RGB/XYZ/YCbCr status
// implicitly via the image format, rather than the actual tagging.
switch (mp_imgfmt_get_forced_csp(par->imgfmt)) {
case PL_COLOR_SYSTEM_RGB:
frame->repr.sys = PL_COLOR_SYSTEM_RGB;
frame->repr.levels = PL_COLOR_LEVELS_FULL;
break;
case PL_COLOR_SYSTEM_XYZ:
frame->repr.sys = PL_COLOR_SYSTEM_XYZ;
break;
case PL_COLOR_SYSTEM_UNKNOWN:
if (!frame->repr.sys)
frame->repr.sys = pl_color_system_guess_ycbcr(par->w, par->h);
break;
default: break;
}

if (fp->hwdec) {

struct mp_imgfmt_desc desc = mp_imgfmt_get_desc(par->imgfmt);
Expand Down

2 comments on commit ef6052c

@mlampe
Copy link

@mlampe mlampe commented on ef6052c Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch breaks hwdec=vdpau. Looks all green now.

@kasper93
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this help #15357?

Please sign in to comment.