-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Want to work on mpv? #13608
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
I have a very rough proof-of-concept for managing plugins via My current opinion from working on this is that the ideal long term solution would be for Also why hand-write markdown tables in here instead of just using github labels? It seems much more flexible. E.g you can have |
i am not really writing the table by hand though. various reasons:
|
Any more info on the calculateWindowPosition requirements? Or on the advantage of a nonlinear function here |
the hope is to considerably simplify the whole function. atm it's a lot of ifs and it's hard to know/see what those are for. the function also handles the case that the window changes screens or the screen resolution changes (when in fs), and the window is placed relative at the same position but the same size as before. with a linear function this would place the window off-screen in some cases. also it seems the function broke a bit over the iterations of new macOS versions and does place the window at weird positions in some cases. |
I implemented a script manager some time ago, maybe it's not the best solution, hope it can provide some ideas. https://github.com/mpv-easy/mpsm-scripts These are some of the problems encountered during implementation
|
Enabled the ruff python linter in CI, and resolved the issues that were detected by it. Ruff was used due to it's faster checking compared with other linters like pylint. This was added to resolve the python linting request in mpv-player#13608.
Enabled the ruff python linter in CI, and resolved the issues that were detected by it. Ruff was used due to it's faster checking compared with other linters like pylint. This was added to resolve the python linting request in mpv-player#13608.
Enabled the ruff python linter in CI, and resolved the issues that were detected by it. Ruff was used due to it's faster checking compared with other linters like pylint. This was added to resolve the python linting request in mpv-player#13608.
Enabled the ruff python linter in CI, and resolved the issues that were detected by it. Ruff was used due to it's faster checking compared with other linters like pylint. This was added to resolve the python linting request in mpv-player#13608.
Enabled the ruff python linter in CI, and resolved the issues that were detected by it. Ruff was used due to it's faster checking compared with other linters like pylint. This was added to resolve the python linting request in #13608.
just a heads-up, i added a bunch of new macOS TODOs. |
Hello @Akemi, I can work with the task |
@ilkermeliksitki i believe @sfan5 added this to the list, pinging him since i am not sure what this encompasses. |
Hi @Akemi, do you know if anyone is currently working on |
as far as i know, no. feel free to. |
mpv-build is collection of scripts to compile mpv and select dependencies, intended for situations where recent software is not available from the repositories. There's also a package template for debian-based distros.
|
1 and 3 could be single workflow definition run on multiple targets (as matrix) for this reason. Those scripts should work generally "anywhere". So we could have a matrix to invoke them on a range of target platforms, that we consider as "currently supported". We can start with single target obviously, too minimize complexity and expand if needed. |
Thank you @sfan5 and @kasper93 for the helpful suggestions. I started tackling the first point of task and for now I got the following
|
mpv-build does not build libmpv by default, working as intended. |
you want to work on mpv and don't know where to start? there are open issues that could possibly be fixed. though this might not be a good or easy start into mpv.
there are various things that still need to be done, with varying difficulties and different scopes. some of these are a good start into our code and can be done independently from any other tasks. anyway, the plan is to finish every task on the list, let everyone know of the current status, keeping track of people working on those tasks and coordinating that work properly. if you want to do any of those yourself, just let us know and we will plan appropriately and try to assist you as well as possible.
General
fix remaining lua lint warnings ➜add Python linting to CI ➜port our website to an up-to-date version of Middleman / RubyLinux
macOS
calculateWindowPosition
function with a nonlinear functionWindows
Legend
Table Editor
Read, edit and output Markdown tables: https://tableconvert.com/markdown-to-markdown
The text was updated successfully, but these errors were encountered: