Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICC profile uses display peak while playing SDR content on HDR display #15411

Open
6 tasks done
Norgerman opened this issue Nov 30, 2024 · 2 comments
Open
6 tasks done
Labels

Comments

@Norgerman
Copy link

Norgerman commented Nov 30, 2024

mpv Information

mpv a283f66 Copyright © 2000-2024 mpv/MPlayer/mplayer2 projects
 built on Nov 28 2024 16:48:18
libplacebo version: v7.350.0
FFmpeg version: 6be17a1
FFmpeg library versions:
   libavcodec      61.19.100
   libavdevice     61.3.100
   libavfilter     10.4.100
   libavformat     61.7.100
   libavutil       59.39.100
   libswresample   5.3.100
   libswscale      8.3.100

Other Information

- Windows version: 23H2
- GPU model, driver and version: RTX3080, 566.14
- Source of mpv: https://github.com/shinchiro/mpv-winbuild-cmake/releases
- Latest known working version: https://github.com/shinchiro/mpv-winbuild-cmake/releases/tag/20241123
- Issue started after the following happened:
   1. enable windows HDR
   2. enable ICC profile
   3. playing SDR content

Display infomation:
display

Reproduction Steps

  1. enable windows HDR
  2. enable ICC profile
  3. playing SDR content
  4. if set target-peak to 203 will playing as expected. It seems using peak(1405) from windows.

simple mpv.config, icc file and sample video attached

Expected Behavior

set target-peak=203 in mpv.conf.

correct

Actual Behavior

wrong

Log File

mpv.log

Sample Files

sample.zip

I carefully read all instruction and confirm that I did the following:

  • I tested with the latest mpv version to validate that the issue is not already fixed.
  • I provided all required information including system and mpv version.
  • I produced the log file with the exact same set of files, parameters, and conditions used in "Reproduction Steps", with the addition of --log-file=output.txt.
  • I produced the log file while the behaviors described in "Actual Behavior" were actively observed.
  • I attached the full, untruncated log file.
  • I attached the backtrace in the case of a crash.
@kasper93
Copy link
Contributor

kasper93 commented Nov 30, 2024

Recently we added display nits retrieval for target-peak, so it now uses true display peak instead. Though for SDR video this has this effect as above.

You can try inverse-tone-mapping if you want to output HDR. Or use target-peak=203 for SDR media. I will think how we can handle it best in default config.

Related: #8249

@Norgerman
Copy link
Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants