Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misaligned subtitles after window resize and reload. #15523

Open
6 tasks done
Sneakpeakcss opened this issue Dec 16, 2024 · 2 comments · May be fixed by #15538
Open
6 tasks done

Misaligned subtitles after window resize and reload. #15523

Sneakpeakcss opened this issue Dec 16, 2024 · 2 comments · May be fixed by #15538
Labels

Comments

@Sneakpeakcss
Copy link

Sneakpeakcss commented Dec 16, 2024

mpv Information

mpv v0.39.0-502-ge52f9758 Copyright © 2000-2024 mpv/MPlayer/mplayer2 projects
 built on Dec 13 2024 18:06:16
libplacebo version: v7.350.0 (v7.349.0-30-g056b852-dirty)
FFmpeg version: N-118059-g90af8e07b
FFmpeg library versions:
   libavcodec      61.26.100
   libavdevice     61.4.100
   libavfilter     10.6.101
   libavformat     61.9.100
   libavutil       59.50.100
   libswresample   5.4.100
   libswscale      8.12.100

Other Information

- Windows version: 22H2
- GPU model, driver and version: RX570 24.9.1
- Source of mpv: zhongfly
- Latest known working version: 20240414-git-6a8b130
- Issue started after the following happened: 20240421-git-b364e4a

Reproduction Steps

  • set sub-align-x left (this happens with all alignments, even center if sub-margin-x is high enough.
  • open .srt subtitles
  • resize the window by either dragging or toggling fullscreen
  • reload the subtitle by either sub-reload or dragging any other .srt sub over mpv
  • resize the window again

Expected Behavior

Subtitles should retain alignment at all times like in the last working 20240414-git-6a8b130 version:

last.working.20240414-git-6a8b130.mp4

Actual Behavior

Margin seems to be re-adjusted after every reload + window size change:

new.20241215-git-e52f975.mp4

Turning off sub-scale-by-window and sub-scale-with-window doesn't change anything, and only setting sub-margin-x 0 has any effect. Margin y doesn't have any issues.

Unfortunately the only old builds available now are the sourceforge ones, and there's a week window between the the working/not builds: 6a8b130...b364e4a

Log File

log.txt

Sample Files

test.zip

I carefully read all instruction and confirm that I did the following:

  • I tested with the latest mpv version to validate that the issue is not already fixed.
  • I provided all required information including system and mpv version.
  • I produced the log file with the exact same set of files, parameters, and conditions used in "Reproduction Steps", with the addition of --log-file=output.txt.
  • I produced the log file while the behaviors described in "Actual Behavior" were actively observed.
  • I attached the full, untruncated log file.
  • I attached the backtrace in the case of a crash.
@Dudemanguy
Copy link
Member

I can't reproduce on my end.

@na-na-hi na-na-hi linked a pull request Dec 18, 2024 that will close this issue
@na-na-hi
Copy link
Contributor

Fixed by #15538.

I can't reproduce on my end.

I can reproduce on my end. Use the provided config files. There is no need to resize window, just rerendering by pressing v to hide and show the subtitle is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants