Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msgpack stream write 'drain'? #43

Open
llint opened this issue Feb 10, 2018 · 0 comments
Open

msgpack stream write 'drain'? #43

llint opened this issue Feb 10, 2018 · 0 comments

Comments

@llint
Copy link

llint commented Feb 10, 2018

In the Stream wrapper of msgpack.js, it seems that the send function doesn't handle the underlying stream's writable.'drain' event, even though in most cases, stream.write would succeed, but for high volume data pumping scenarios, when stream.write returns false, the writable.'drain' event should be used to resume writing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant