Fix crash when function result type contains a constructor property #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2023
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the second issue in #2934
superjson@2.1.0added this feature which started throwing on our introspection API where the body contains a jsonschema that was generated from a typescript interface that contains a property named "constructor".This PR reverts the update and quarantines
superjsonin renovatebot until fixed (flightcontrolhq/superjson#279).I tried switching to
devalue, but they are not extensible enough to build this on top of.Adding a test case that breaks one of the backend tests