Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_cases.csv is ambiguous? #123

Open
mattnite opened this issue Oct 16, 2019 · 1 comment
Open

test_cases.csv is ambiguous? #123

mattnite opened this issue Oct 16, 2019 · 1 comment

Comments

@mattnite
Copy link

Hey, just a heads up that test_cases.csv is hashing the input as a string and not as a binary. Is this intended? From my perspective, it looks like the input is intended to be base16 encoded binary.
@Stebalien
Copy link
Member

I agree. At this point, "known" is probably more accurate than "intended".

If you'd like to change this, go for it. If you do that, please update https://github.com/multiformats/go-multihash/blob/249ead2008065c476a2ee45e8e75e8b85d846a72/spec_test.go#L70 to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @mattnite