"returns with nonliteral" expectations not working

[Gustrucco]

I tried to use an expectation which case was exactly like this one:

expectation "`getAge` must not return a hardcoded value:
  %% equivalent to Intransitive:getAge Returns:WithNonliteral
  within `getAge` returns with nonliteral;
 

Here you can try it with this solution:

module Inodoro
  @cafeina_en_sangre = 90
  
  def self.compinche=(compinche)
    @compinche = compinche
  end
  
  def self.cafeina_en_sangre
    @cafeina_en_sangre  
  end
  
  def self.compinche
    @compinche
  end
end

module Eulogia
  @enojada = false
  
  def self.enojada?
    @enojada 
  end
end

module Mendieta
  @ganas_de_hablar = 5
  
  def self.ganas_de_hablar=(ganas_de_hablar)
    @ganas_de_hablar = ganas_de_hablar
  end
  
  def self.ganas_de_hablar
    @ganas_de_hablar
  end
end

[julian-berbel]

So, the problem here is with ruby's implicit return. The following code:

module Inodoro
  def self.cafeina_en_sangre
    @cafeina_en_sangre  
  end
end

Produces this ast:

Object "Inodoro" (Method "cafeina_en_sangre" [] (Reference "@cafeina_en_sangre"))

Expectation returns with nonliteral searches for a Return expression where the returned value is not a literal, but since no Return expression is found anywhere, it fails. This same expectation works properly with an explicit return:

module Inodoro
  def self.cafeina_en_sangre
    return @cafeina_en_sangre  
  end
end

But it's not what one would normally do in ruby. We mulled over the idea of implicitly adding a Return expression to the last member of a sequence for ruby with @flbulgarelli, but this would likely cause a lot of other collateral failed expectations, such as returning the result of an assignment.

This isn't an easy solve, so we'll be leaving it for the future.

[Gustrucco]

Crystal clear. Thanks!