Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Font / Theme #282

Closed
3 tasks
Bubobubobubobubo opened this issue May 3, 2024 · 6 comments
Closed
3 tasks

Custom Font / Theme #282

Bubobubobubobubo opened this issue May 3, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@Bubobubobubobubo
Copy link
Contributor

Bubobubobubobubo commented May 3, 2024

I would like to start working on an option to choose a different font / theme. There are a few nice options here for fonts (https://www.nerdfonts.com/font-downloads), we could also include weird glyphs just for fun.

Proposed plan:

  •  Choose a few fonts with clear open-source/libre licensing
  • Simplify the addition of new fonts by users/contributors
  • cmdk submenu to select a font and/or theme (Cmd+J) menu (?)

I already have something working on my personal branch. I just need a bit more help to tame the React-based fancy submenu :)

@Bubobubobubobubo Bubobubobubobubo changed the title Custom Fonts Custom Font / Theme May 4, 2024
@Bubobubobubobubo
Copy link
Contributor Author

flok_contrib.mov

Got this working. Will probably need help testing / theming stuff :)

@munshkr
Copy link
Owner

munshkr commented May 5, 2024

OMG Thank you!! I've been wanting to add these UI settings for a long time! :)

@Bubobubobubobubo
Copy link
Contributor Author

Bubobubobubobubo commented May 5, 2024

A small update on my future PR.

Fonts

I have added a small font collection with font preview in the menu. It is a mix of popular and more niche fonts. JGS and Steps Mono were crafted by french live coders Adel Faure and Raphaël Bastide and released on Velvetyne (https://velvetyne.fr/).

  • JetBrains
  • Monaco
  • Courier
  • Monocraft
  • BigBlue Terminal
  • JGS
  • Steps Mono
  • IBM Plex Mono
  • Inconsolata

Capture d’écran 2024-05-05 à 18 29 22

Themes

I don't really like working on themes. It is an highly subjective/divise topic and no matter what you do, people will always complain :) Anyway, I have added a few themes that are readable and vanilla-flavoured. There is still a bit of work to do to tame the TypeScript compiler and to arrange the themes so they look nice and don't suddenly break with ugly colors. It would be nice to have some help on that matter, I really don't like frontend work.

  • Dracula
  • Monokai
  • Gruvbox (Dark)
  • Ayu (Dark)
  • Tokyo Night
  • Nord

Capture d’écran 2024-05-05 à 18 34 22

@igormpc
Copy link

igormpc commented May 5, 2024

great work Bubobubobubobubo !! maybe add also gruvbox / gruvbox-dark themes?? really waiting anxious for vim mode/edit :D !! thx in advance !!

@Bubobubobubobubo
Copy link
Contributor Author

great work Bubobubobubobubo !! maybe add also gruvbox / gruvbox-dark themes?? really waiting anxious for vim mode/edit :D !! thx in advance !!

I have refactored my work and replaced weird themes by well known ones. I also added GruvBox Dark. The light version was not rendering beautifully so I scraped it 🧑‍🔧 Note that you can already build/try my fork if you want to try it!

@munshkr munshkr added the enhancement New feature or request label May 18, 2024
@Bubobubobubobubo
Copy link
Contributor Author

I am closing this issue since work is underway with #283.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants