Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing static for a function in m4f haetae2 implementation (in reduce.h) #356

Open
rben-dev opened this issue Aug 19, 2024 · 0 comments
Open

Comments

@rben-dev
Copy link

The m4f haetae2 implementation of pqm4 misses a static keyword in

inline int32_t _montgomery_reduce(int64_t a) {
(the other variants are not impacted since they use an implementation of the function in the .c file). This can produce compilation errors (missing symbol) in some cases where the compiler decides to not inline the function in compilation units.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant