Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify worker modal #155

Open
3 tasks
mvantellingen opened this issue May 15, 2015 · 2 comments
Open
3 tasks

Simplify worker modal #155

mvantellingen opened this issue May 15, 2015 · 2 comments

Comments

@mvantellingen
Copy link
Owner

We should have three options:

  • Celery
  • Synchronous (just set CELERY_ALWAYS_EAGER=True)
  • Crontab (create management task to update repo)

This will remove the option LOCALSHOP_ISOLATE (which is equal to CELERY_ALWAYS_EAGER afaik)

The package update queue should just be a simple django modal and should be available in the management interface.

@canassa
Copy link
Collaborator

canassa commented May 15, 2015

Running Localshop with CELERY_ALWAYS_EAGER=True is not really an option. The main problem is that we don't have enough time in a single request to fetch the package metadata from PyPI, download the binaries and return the response to pip.

That may work if the package is small and does not contains many releases, but if the package is big (e.g.: Celery) The request will take too long which will cause pip to timeout and retry the request, causing Localshop to start another slow process in parallel.

@mvantellingen
Copy link
Owner Author

Well LOCALSHOP_ISOLATED seems like a custom variant of CELERY_ALWAYS_EAGER. See https://github.com/mvantellingen/localshop/blob/0d320315b7c7a31854abd332cf624ed349771c0e/docs/settings.rst#localshop_isolated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants