Fix failing extension check tests

[mahendrapaipuri]

No description provided.

[github-actions]

Thank you for making this pull request.

Did you know? You can try it on Binder: or .

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/mahendrapaipuri/jupytext.git@fix_browser_check_test

(this requires nodejs, see more at Developing Jupytext)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.03%. Comparing base (f2e1b9d) to head (a567f68).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1297   +/-   ##
=======================================
  Coverage   97.03%   97.03%           
=======================================
  Files          29       29           
  Lines        4481     4481           
=======================================
  Hits         4348     4348           
  Misses        133      133           

Flag	Coverage Δ
external	75.10% <ø> (ø)
functional	88.53% <ø> (ø)
integration	77.23% <ø> (ø)
unit	66.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mwouts]

Thanks @mahendrapaipuri - that's a good start! I think I've seen this browser_check test twice, we will need to restore that one too.

Then there was a problem with the test-ui step of the CI, and also with the automated update of the snapshots, but I can do without them for now, no pressure!

[mahendrapaipuri]

It is coming from upstream JupyterLab for the latest 4.3.3 version. Seems like empty LANG locale setting is causing the error

[mahendrapaipuri]

@mwouts Could you point to the CI run where update snapshots is failing?

[mwouts]

@mwouts Could you point to the CI run where update snapshots is failing?

Yes! I think this one was the last time I tried: https://github.com/mwouts/jupytext/actions/runs/12338406420

[mahendrapaipuri]

I think extension check test is "fixed" temporarily until the upstream fixes the issue in JupyterLab.

[mwouts]

Thank you @mahendrapaipuri . I also had to deactivate the UI tests:

https://github.com/mwouts/jupytext/blob/main/.github/workflows/step_tests-ui.yml#L46-L47

The last time I saw the UI test fail was this run: https://github.com/mwouts/jupytext/actions/runs/12338902735/job/34434556533

[krassowski]

Heads up, setting export LANG="en_US.utf8" should no longer be needed since release of JupyterLab 4.3.4 today. The issue appears to ultimately be a bug in headless chrome distribution (see the links in the JupyterLab issue jupyterlab/jupyterlab#17079)