Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research vBulletin moved thread #196

Open
JN-Jones opened this issue May 7, 2016 · 0 comments
Open

Research vBulletin moved thread #196

JN-Jones opened this issue May 7, 2016 · 0 comments
Labels
c:vBulletin Converter: vBulletin

Comments

@JN-Jones
Copy link
Contributor

JN-Jones commented May 7, 2016

Source in the thread modules:

        $insert_data['closed'] = int_to_01($data['open']);

        if($insert_data['closed'] == 'no')
        {
            $insert_data['closed'] = '';
        }

        if($data['open'] == '10')
        {
            $insert_data['closed'] = 'moved|'.$this->get_import->tid($data['pollid']);
        }

As int_to_01 never returns no the first if is never used. While I can confirm that all threads where open has the value 10 have a pollid I'm not sure whether vb really uses the pollid column as moved thread id column which looks simply wrong...

@JN-Jones JN-Jones added the c:vBulletin Converter: vBulletin label May 7, 2016
@JN-Jones JN-Jones added this to the 1.8.8 milestone May 7, 2016
@Stefan-MyBB Stefan-MyBB removed this from the 1.8.8 milestone Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:vBulletin Converter: vBulletin
Projects
None yet
Development

No branches or pull requests

2 participants