Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zooming while other pins loading opens a report #5225

Open
mattbaker-digital opened this issue Oct 22, 2024 · 1 comment
Open

Zooming while other pins loading opens a report #5225

mattbaker-digital opened this issue Oct 22, 2024 · 1 comment

Comments

@mattbaker-digital
Copy link

Describe the bug
Pinch zooming in android app on map while only some of the pins have loaded and the loading animation in top left is visible results in a report being opened as though you had tapped on the pin.

To Reproduce
Steps to reproduce the behavior:

  1. Open the app and go to the map view
  2. Zoom in until some pins have loaded.
  3. Pinch zoom in further to load more pins.
  4. While loading animation is visible in top left, zoom in more.

Expected behavior
Map displays zoomed area with pins loaded and report not opened until tapped on a pin.

Screenshots
https://1drv.ms/v/s!Ajr10IwsuvM9hOEooKcvcH20ZlbJrA

Smartphone (please complete the following information):

  • Device: Google Pixel 8 Pro
  • OS: Android 14
  • Browser: App
  • App version: 3.0.1
@dracos
Copy link
Member

dracos commented Oct 22, 2024

Thanks for your report. I have replicated it locally on an iPhone, so it's not Android specific. I don't /think/ it's to do with the pins loading - I think I can have it happen when they are not. The issue appears to be if one (or both?) of the fingers used in the pinch zoom is over a pin when you start (end?) the pinch zoom gesture, the map takes this as a tap of that pin rather than only a pinch zoom. But not always?

Nothing has changed in the map handling code recently, apart from a fix to cancel touch events should you move your finger off the zoom button - which sounds like it could be related, but I don't think it should be? This might be tricky to track down, but hopefully we'll be able to work it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants