From 427bfed55fd82ee0db306431b486bfce8c1ee418 Mon Sep 17 00:00:00 2001 From: Jeremy Rand Date: Mon, 13 Jun 2022 14:57:36 +0000 Subject: [PATCH] FIXUP outdated comments --- src/qt/nametablemodel.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/qt/nametablemodel.cpp b/src/qt/nametablemodel.cpp index 667257dc7b..a8348fe989 100644 --- a/src/qt/nametablemodel.cpp +++ b/src/qt/nametablemodel.cpp @@ -72,8 +72,6 @@ class NameTablePriv std::map vNamesO; // confirmed names (name_list) - // TODO: Set name and value encoding to hex, so that nonstandard - // encodings don't cause errors. UniValue params(UniValue::VOBJ); UniValue options(UniValue::VOBJ); @@ -107,6 +105,8 @@ class NameTablePriv continue; } + // TODO: Properly handle non-ASCII names/data. + const std::string hexName = maybeName.get_str(); std::string name; try @@ -151,8 +151,6 @@ class NameTablePriv } // unconfirmed names (name_pending) - // TODO: Set name and value encoding to hex, so that nonstandard - // encodings don't cause errors. UniValue pendingNames; try { @@ -178,6 +176,8 @@ class NameTablePriv continue; } + // TODO: Properly handle non-ASCII names/data. + const std::string hexName = maybeName.get_str(); std::string name; try @@ -562,6 +562,8 @@ QString NameTableModel::update(const QString &name, const std::optional UniValue params(UniValue::VOBJ); + // TODO: Properly handle non-ASCII names/data. + try { const QString hexName = NameTableModel::asciiToHex(name);