-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default text color is too dark on vte-terminal #342
Comments
i am not aware of tilix specifically but gnome-terminal for instance have it in it's own configuration i guess you need to contact tilix developers on this |
Actually, looking closely it is not just Tilix, and it's not exactly bold. I just noticed it most there. It seems that everywhere Materia causes fonts to be heavier. Do you know what causes this? Switching to a theme like Arc makes the issue disappear immediately. |
try adding to your * {
text-shadow: none;
font-weight: normal;
} (Materia is using font-weight |
This had no effect (I restarted GNOME Shell). Is there somewhere in the Materia theme CSS that I can change the weight? |
you can try doing it in some particular application using GtkInspector's CSS tab |
@tliron Is that only in the terminal apps? Could you attach screenshot(s) to know exactly which/where font you are talking about?
If you are talking about buttons or tabs, it is intentional as in Material Design medium font weight (
Please search |
Thank you for your detailed response! I tried commenting out those lines (from |
the only difference i see is what on Materia screenshot text is slightly darker |
The end effect is darker, but if you look closely it's either due to added weight or some change in anti-aliasing. It might seem subtle, but in everyday work it does make Materia unusable for me. I would be happy to patch it myself, but first we need to figure out what is causing this. Removing the Do you have some ideas that I can add as css overrides to GtkInspector to try it out? |
try lighter fg color font rendering indeed could happen slightly different in depend of color |
Can you explain what you mean? Where would I change that in css? |
for just testing purpose you can set it globally: * {
color: #999999;
} |
This changes the colors for most things ... but not the terminal font. It seems that terminal font css comes from somewhere else. Actually you can try it yourself in GNOME terminal (Tilix uses the same VT widget). |
anyway just for testing purpose could you override the foreground color in terminal preferences? |
Overriding seems to work. But it seems that the defaults are somehow different in Materia as compared to other GTK themes. |
just to clear it up, after changing font color "font rendering" problem got fixed? |
if not please show the screenshots with the same fg/bg colors but different themes |
If I set Tilix to use the internal color scheme, it is consistent across all GTK themes. But if I set Tilix to use "Use theme colors for foreground/background", then the problem appears. By the way, the Materia CSS does include some custom theming for Tilix. |
by "problem" you mean what Materia is not using your favorite color as terminal foreground? |
@nana-4 btw what do you think about generating some terminal themes for Materia users? now you can just set terminal colors in (currently Materia* themes there are just using fallback auto-generated terminal palette which looks quite off from the material design) |
By "problem" I mean the issue you can see in my attached photos above, which now we realize is probably due to a wrong "black" color. There's no need to create a special theme for Tilix: actually, it already includes a material theme and there are many community themes. However ... the included material theme is dark, and I personally prefer my terminal to match the desktop theme (I use the default Materia, which is light). So I always have "Use theme colors for foreground/background" set and I'm usually happy with whatever GTK theme I use ... except Materia which has this issue. :) |
that sounds like "yes" answer to the question above |
Well, you asked about "favorite" -- specifically we are talking about the terminal inheriting the GTK theme. It's not always my favorite, but it is matching. :) |
do you mean in Materia TextView and Terminal colors are not matching? |
Ah, I got it. It seems the terminal screen (VT widget?) don't understand or ignore the text alpha value. Materia uses This problem should really be fixed upstream, but I'll add a workaround for this. Thanks for your report. |
Thanks @nana-4, I would be happy to help test. I'll subscribe to #157. Thanks also @actionless for your assistance! |
For what it's worth, I found the base16 Tilix themes to have quite a few that are a good match for Materia. There is even a theme called "Materia", though I don't think it's related to this project. |
@tliron to learn how to use those templates see this tutorial: https://gist.github.com/actionless/f9ad9e5ab9eac414dac8a3392beb3ad5 just at the last step choose |
@actionless Thanks, there are quite a lot of themes already included in the repo linked above. |
yeah, but you mentioned what you prefer light themes, and it's easier to swap light/dark colors from the UI |
So sorry for my delay in responding. My guess was wrong. At first I thought adding this will work: vte-terminal { color: rgba(0, 0, 0, 0.87); } In fact, however, VTE's text color is hard-coded with So, please manually edit the theme color variable (from I'm gonna close this as an upstream issue. |
Is there a way to avoid the bold font in the terminal? (I'm using Tilix, specifically)
It seems there is no way to change this within terminals, because they inherit the font selection from the theme. It would be great if there were a configuration option to avoid this.
The text was updated successfully, but these errors were encountered: