Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forces use of either individual msgid config files or a symbolic link #151

Open
skliper opened this issue Oct 31, 2023 · 1 comment
Open

Comments

@skliper
Copy link
Contributor

skliper commented Oct 31, 2023

Is your feature request related to a problem? Please describe.

ci_lab/arch_build.cmake

Lines 22 to 27 in 2930b94

foreach(CI_LAB_CFGFILE ${CI_LAB_PLATFORM_CONFIG_FILE_LIST})
generate_config_includefile(
FILE_NAME "${CI_LAB_CFGFILE}"
FALLBACK_FILE "${CMAKE_CURRENT_LIST_DIR}/config/default_${CI_LAB_CFGFILE}"
)
endforeach()

Not clear why we can't consistently support an override w/ a custom file name such that MIDs can all be in one file without the extra clutter of a symbolic link.

Describe the solution you'd like
Something like nasa/LC#98, which came from SC:
https://github.com/nasa/SC/blob/ab3a9a03aee8fb9826077c0492f4b7698132c057/arch_build.cmake#L29-L40

Describe alternatives you've considered
None

Alternative
Consider writing a wrapper function so this can be consistently handled for configurations that lend themselves to management from one file (perfids, msgids).

Requester Info
Jacob Hageman - NASA/GSFC

@skliper
Copy link
Contributor Author

skliper commented Oct 31, 2023

@jphickey - thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant