Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in file extension does not result in error #2992

Open
celskeggs opened this issue Oct 29, 2024 · 0 comments
Open

Typo in file extension does not result in error #2992

celskeggs opened this issue Oct 29, 2024 · 0 comments
Labels
bug High Priority High Priority issue that needs to be resolved.

Comments

@celskeggs
Copy link

F´ Version v3.4.3-117-g65b9e4d9d
Affected Component build system

Problem Description

I created a file with the extension .fp instead of .fpp and added it to SOURCE_FILES in a module.

set(SOURCE_FILES
  "${CMAKE_CURRENT_LIST_DIR}/mymodule.hpp"
  "${CMAKE_CURRENT_LIST_DIR}/mymodule.fp"
)

Since mymodule.fp is not processed, I expect to get an error in this case. The presence of unrecognized source code is likely not intended, and catching it would help avoid mistakes. (This is most applicable when using a custom autocoder.)

Context / Environment

Execute fprime-util version-check and share the output.

Operating System: Linux
CPU Architecture: x86_64
Platform: Linux-5.15.153.1-microsoft-standard-WSL2-x86_64-with-glibc2.34
Python version: 3.9.18
CMake version: 3.26.5
Pip version: 21.2.3
Pip packages:
    fprime-tools==3.4.5a1
    fprime-gds==3.4.4a3
    fprime-fpp-*==2.2.0a5

How to Reproduce

  1. Create a new file with the extension .fp and add it to an existing SOURCE_FILES list.
  2. Try to build the project.
  3. Notice that the project does not error out.

Expected Behavior

An error should be reported explaining that the file extension cannot be recognized.

@celskeggs celskeggs added the bug label Oct 29, 2024
@LeStarch LeStarch added the High Priority High Priority issue that needs to be resolved. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug High Priority High Priority issue that needs to be resolved.
Projects
None yet
Development

No branches or pull requests

2 participants