Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP-241 - Use ruff to enforce import ordering. #5

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

owenlittlejohns
Copy link
Member

Description

During DAS-2108 @flamingbear and I noticed that imports aren't ordered in HyBIG (see PR here). The Swath Projector doesn't get many PRs, so instead of folding this in during a later PR, I've added it now so we don't forget.

Jira Issue ID

N/A

Local Test Steps

N/A

PR Acceptance Checklist

  • Jira ticket acceptance criteria met.
  • CHANGELOG.md updated to include high level summary of PR changes.
  • docker/service_version.txt updated if publishing a release.
  • Tests added/updated and passing.
  • Documentation updated (if needed).

Copy link
Member

@flamingbear flamingbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You could if you wanted, add this commit to the ignored commits also since it's a bunch of formatting changes.

@owenlittlejohns owenlittlejohns merged commit 3cabffd into main Apr 17, 2024
4 checks passed
@owenlittlejohns owenlittlejohns deleted the IP-241-ruff-order-imports branch April 17, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants