Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axis): fix error when showing tick only #3882

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

netil
Copy link
Member

@netil netil commented Sep 20, 2024

Issue

#3881

Details

Do not call .getBBox() for empty node

Do not call .getBBox() for empty node

Ref naver#3881
@netil netil added the bug label Sep 20, 2024
@netil netil self-assigned this Sep 20, 2024
@coveralls
Copy link

Coverage Status

coverage: 94.246%. remained the same
when pulling d853337 on netil:axis#3881
into 385907e on naver:master.

@netil netil merged commit 705947f into naver:master Sep 20, 2024
10 checks passed
@netil netil deleted the axis#3881 branch September 20, 2024 02:42
netil pushed a commit to netil/billboard.js that referenced this pull request Sep 20, 2024
Fix param type to not be optional

Ref naver#3882
netil added a commit that referenced this pull request Sep 20, 2024
Fix param type to not be optional

Ref #3882

Co-authored-by: netil <netil@netil.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants