refactor: remove block vrf verification from epoch manager #12447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stedfn
changed the base branch from
master
to
stefan/remove_verify_chunk_header
stedfn
changed the title
stedfn
requested review from
tayfunelmas,
pugachAG and
shreyan-gupta
and removed request for
a team and
tayfunelmas
| header.height(), | ||
| let validator = | ||
| self.epoch_manager.get_block_producer_info(header.epoch_id(), header.height())?; | ||
| crate::signature_verification::verify_block_vrf( |
There was a problem hiding this comment.
nit: could we put verify_block_vrf as part of imports instead of fully qualifying?
| self.get_block_producer_info(epoch_id, height).map(|validator| validator.take_account_id()) | ||
| } | ||
|
|
||
| fn get_block_producer_info( |
There was a problem hiding this comment.
@pugachAG, how comfortable are we with exposing block producer info?
There was a problem hiding this comment.
don't see any issues with that, especially considering that we already expose chunk producer info this way
pugachAG
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes block vrf verification from epoch manager