refactor: remove header signature verification from epoch manager #12467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugachAG
approved these changes
Nov 18, 2024
|
|
||
| /// This function requires that the previous block of `header` has been processed. | ||
| /// If not, it returns EpochError::MissingBlock. | ||
| pub fn verify_header_signature_with_epoch_manager( |
There was a problem hiding this comment.
nit: let's make it verify_block_header_signature_with_epoch_manager
| epoch_manager.get_block_producer_info(header.epoch_id(), header.height())?; | ||
| match epoch_manager.get_block_info(header.prev_hash()) { | ||
| Ok(block_info) => Ok(verify_header_signature(header, block_producer, block_info)), | ||
| Err(_) => return Err(EpochError::MissingBlock(*header.prev_hash()).into()), |
There was a problem hiding this comment.
nit: you do not need return here
| block_producer: ValidatorStake, | ||
| block_info: Arc<BlockInfo>, | ||
| ) -> bool { | ||
| if block_info.slashed().contains_key(block_producer.account_id()) { |
There was a problem hiding this comment.
I would rather just remove this function and push the functionality inline to verify_header_signature_with_epoch_manager.
It's not trivial to imagine this function should be checking slashed block producer from block info of previous block.
There was a problem hiding this comment.
+1, this slashing check is annoying and useless at this point, would be great to remove it
stedfn
changed the base branch from
master
to
stefan/remove_verify_chunk_header
stedfn
changed the base branch from
stefan/remove_verify_chunk_header
to
stefan/em_sig_ver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.