Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

near-vm: update rkyv to 0.8 #12504

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

near-vm: update rkyv to 0.8 #12504

wants to merge 1 commit into from

Conversation

nagisa
Copy link
Collaborator

@nagisa nagisa commented Nov 22, 2024

This patch is best accompaned with the following short presentation https://www.youtube.com/watch?v=ON4z2LbTD-4. For the most part the structure does not change significantly, but there is quite a bit more confidence, that the right thing is being done. The executables might even be portable between machines or neard builds now!

@nagisa nagisa requested a review from a team as a code owner November 22, 2024 16:07
This patch is best accompaned with the following short presentation
https://www.youtube.com/watch?v=ON4z2LbTD-4. For the most part the
structure does not change significantly, but there is quite a bit more
confidence, that the right thing is being done. The executables might
even be portable between machines or neard builds now!
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 24 lines in your changes missing coverage. Please review.

Project coverage is 69.97%. Comparing base (7da5c8f) to head (c0ebc70).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
runtime/near-vm/engine/src/universal/engine.rs 45.45% 9 Missing and 3 partials ⚠️
runtime/near-vm/engine/src/universal/executable.rs 66.66% 5 Missing and 3 partials ⚠️
runtime/near-vm/types/src/archives.rs 0.00% 3 Missing ⚠️
runtime/near-vm/compiler/src/section.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12504   +/-   ##
=======================================
  Coverage   69.96%   69.97%           
=======================================
  Files         838      838           
  Lines      169135   169066   -69     
  Branches   169135   169066   -69     
=======================================
- Hits       118338   118305   -33     
+ Misses      45666    45642   -24     
+ Partials     5131     5119   -12     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (+<0.01%) ⬆️
db-migration 0.16% <0.00%> (?)
genesis-check 1.28% <0.00%> (+<0.01%) ⬆️
linux 69.29% <66.66%> (+<0.01%) ⬆️
linux-nightly 69.51% <66.66%> (+0.01%) ⬆️
macos 51.11% <0.00%> (+0.02%) ⬆️
pytests 1.59% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.40% <0.00%> (+<0.01%) ⬆️
unittests 69.79% <66.66%> (+<0.01%) ⬆️
upgradability 0.20% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant