Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resharding): Skip old ShardUIds in get_new_flat_storage_head() #12505

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(resharding): Skip old ShardUIds in get_new_flat_storage_head() #12505

wants to merge 1 commit into from
+16 −8

Commits on Nov 22, 2024

  1. fix(resharding): Skip old ShardUIds in get_new_flat_storage_head() 

    This function finds the chunk in the last final block by looking for
the one with the same shard ID as one of the shards in the current
block's epoch. But if there is a skipped chunk in a child shard in the
first block after a resharding, then the old chunk in the child's
shard_index will be the parent's chunk from the previous epoch.  Then
this shard ID comparison doesn't work and we get an error. Fix it by
comparing the current ShardUID to the ShardUID of the chunk, and
returning None if they don't match.
    @marcelo-gonzalez
    marcelo-gonzalez committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    d256306 View commit details
    Browse the repository at this point in the history