Skip to content
This repository has been archived by the owner on Feb 11, 2023. It is now read-only.

DefaultCallback on Login should process Erros first #10

Open
diogodamiani opened this issue Aug 8, 2018 · 0 comments
Open

DefaultCallback on Login should process Erros first #10

diogodamiani opened this issue Aug 8, 2018 · 0 comments

Comments

@diogodamiani
Copy link

diogodamiani commented Aug 8, 2018

Hi,

I'm using the Facebook Login form, but when the user does not consent the app, it throws a NullReferenceException.

That is the CallStack:

Nemiro.OAuth.dll!Nemiro.OAuth.UniValue.IsNullOrEmpty(Nemiro.OAuth.UniValue value) Line 1136 C# Nemiro.OAuth.dll!Nemiro.OAuth.UniValue.operator !=(Nemiro.OAuth.UniValue x, string y) Line 2067 C# Nemiro.OAuth.LoginForms.dll!Nemiro.OAuth.LoginForms.Login.GetAccessToken(string authorizationCode) Line 400 C# Nemiro.OAuth.LoginForms.dll!Nemiro.OAuth.LoginForms.Login.AuthorizationCode.set(string value) Line 136 C# Nemiro.OAuth.LoginForms.dll!Nemiro.OAuth.LoginForms.Login.DefaultCallback(object sender, Nemiro.OAuth.LoginForms.WebBrowserCallbackEventArgs e) Line 351 C# Nemiro.OAuth.LoginForms.dll!Nemiro.OAuth.LoginForms.Login.webBrowser1_DocumentCompleted(object sender, System.Windows.Forms.WebBrowserDocumentCompletedEventArgs e) Line 274 C# Nemiro.OAuth.LoginForms.dll!Nemiro.OAuth.LoginForms.Login.webBrowser1_DocumentTitleChanged(object sender, System.EventArgs e) Line 236 C#

I think the erros in response should be treated first. Would you mind if I send a pull request?

Cheers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant