Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Document or fix polymorphic interface usages in Neos.Media #4754

Open
mhsdesign opened this issue Nov 15, 2023 · 0 comments
Open

TASK: Document or fix polymorphic interface usages in Neos.Media #4754

mhsdesign opened this issue Nov 15, 2023 · 0 comments
Labels
Backlog A category for things that are okay to be rather 'hidden'

Comments

@mhsdesign
Copy link
Member

mhsdesign commented Nov 15, 2023 •
edited
Loading

Currently we do at check at many places for something like method_exists($adjustment, 'refit').

To make this more transparent i would propose to use @method void refit(object $image) on the interface (as its not breaking). I have seen doctrine and symfony doing this.

Alternatively we can add new interfaces.

Originally posted by @mhsdesign in #4753 (comment)

Related #4816
@mhsdesign mhsdesign changed the title TASK: Document or fix overqualified interface usages TASK: Document or fix polymorphic interface usages Nov 15, 2023
@mhsdesign mhsdesign changed the title TASK: Document or fix polymorphic interface usages TASK: Document or fix polymorphic interface usages in Neos.Media Feb 3, 2024
@mhsdesign mhsdesign added the Backlog A category for things that are okay to be rather 'hidden' label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backlog A category for things that are okay to be rather 'hidden'
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhsdesign