Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases that test the complete set #79

Open
bwaidelich opened this issue Jul 19, 2024 · 0 comments
Open

Add test cases that test the complete set #79

bwaidelich opened this issue Jul 19, 2024 · 0 comments

Comments

@bwaidelich
Copy link
Member

There are quite a lot of tests covering the behavior of each individual rector.
But so far there is no test that covers the behavior of the contentrepository-90 ruleset itself.

IMO we should add that, because it would be a good start to report (and fix) bugs in our rector migration:

  1. Extend the test case reproducing the wrong behavior
  2. Fix set/rules until the tests are green again
bwaidelich added a commit that referenced this issue Jul 19, 2024
@bwaidelich
TASK: Replace usages of Neos.Neos:PrimaryContent
34877e3 
Adjusts the set such that usages of `Neos.Neos:PrimaryContent` are replaced while overrides are still kept

Resolves: #78
Related: #79
@bwaidelich bwaidelich mentioned this issue Jul 19, 2024
Merged
dlubitz added a commit that referenced this issue Sep 24, 2024
@dlubitz
TASK: Replace usages of Neos.Neos:PrimaryContent
f5c3285 
Adjusts the set such that usages of `Neos.Neos:PrimaryContent` are replaced while overrides are still kept

Resolves: #78
Related: #79
dlubitz added a commit that referenced this issue Sep 24, 2024
@dlubitz
TASK: Replace usages of Neos.Neos:PrimaryContent
3f62b19 
Adjusts the set such that usages of `Neos.Neos:PrimaryContent` are replaced while overrides are still kept

Resolves: #78
Related: #79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bwaidelich