From 1f83a4518b043c44880326fe97a0c22c338bf2cd Mon Sep 17 00:00:00 2001 From: Ruilong Li <397653553@qq.com> Date: Fri, 29 Sep 2023 14:11:57 -0700 Subject: [PATCH] dev instructions --- .github/workflows/core_tests.yml | 2 +- .github/workflows/doc.yml | 2 ++ README.md | 25 +++++++++++++++++++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/.github/workflows/core_tests.yml b/.github/workflows/core_tests.yml index 7a06c3947..e3cfd7df5 100644 --- a/.github/workflows/core_tests.yml +++ b/.github/workflows/core_tests.yml @@ -21,6 +21,6 @@ jobs: python-version: "3.8.12" - name: Install dependencies run: | - pip install isort==5.10.1 black[jupyter]==22.3.0 + pip install black[jupyter]==22.3.0 - name: Run Black Format Check run: black . diff_rast/ tests/ examples/ --check diff --git a/.github/workflows/doc.yml b/.github/workflows/doc.yml index 315967649..7431437a1 100644 --- a/.github/workflows/doc.yml +++ b/.github/workflows/doc.yml @@ -2,6 +2,8 @@ name: Docs on: push: branches: [main] + pull_request: + branches: [main] workflow_dispatch: permissions: diff --git a/README.md b/README.md index dde26cb0f..6e54af402 100644 --- a/README.md +++ b/README.md @@ -25,6 +25,31 @@ If you won't touch the underlying CUDA code, you can just install with compiling pip install -e .[dev] ``` +# Development + +## Protect Main Branch over Pull Request. +It is recommend to commit the code into the main branch as a PR over a hard push, as the +PR would protect the main branch if the code break tests but a hard push won't. + +The curret tests that will be triggered by PR: +- `.github/workflows/core_tests.yml`: Black formating. +- `.github/workflows/doc.yml`: Doc build. + +Because we check for black formatting, it is recommend to run black before commit in the code: +``` +black . diff_rast/ tests/ examples/ --check +``` + +## Build the Doc Locally +If you want to contribute to the doc, here is the way to build it locally. The source code of the doc can be found in `docs/source` and the built doc will be in `_build/`. Here are some examples on documentation: [viser](https://github.com/nerfstudio-project/viser/tree/main/docs/source), [nerfstudio](https://github.com/nerfstudio-project/nerfstudio/tree/main/docs), [nerfacc](https://github.com/KAIR-BAIR/nerfacc/tree/master/docs/source). + +``` +pip install -e .[dev] +pip install -r docs/requirements.txt +sphinx-build docs/source _build +``` + + # Brief walkthrough