Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend CI check for correct file headers to JS files. #3269

Open
terhorstd opened this issue Aug 2, 2024 · 1 comment
Open

Extend CI check for correct file headers to JS files. #3269

terhorstd opened this issue Aug 2, 2024 · 1 comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.

Comments

@terhorstd
Copy link
Contributor

terhorstd commented Aug 2, 2024 •
edited
Loading

Describe the bug
The check_copyright_headers.py will notify if code files are missing the usual header. This currently does not include *.js files used in the documentation.

To Reproduce
CI passes, even though doc/htmldoc/static/js/filter_models.js is missing a header.

Expected behavior
Same as for Python and C++ files also the JavaScript and CSS components should have a proper header.
@terhorstd terhorstd mentioned this issue Aug 2, 2024
Merged
@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Aug 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.
Projects
Documentation
Status: To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessica-mitchell @terhorstd