Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add completion support for ntl alias in zsh #6946

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

benhancock
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #6940

In zsh, completions work with the netlify command, but not with the ntl alias. Trying to use tab with ntl does not produce any completions in zsh.

The reason for this is that shell completions are command-specific and do not automatically propagate to aliases without explicit configuration in either the completion script or the shell configuration. The tabtab package, which the CLI uses for its completions, does not support adding these aliases automatically.

Our solution is to manually add the ntl alias to the tabtab-generated completion script once it is created.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

image (1)

Co-authored-by: Dylan Spyer <dylanspyer@gmail.com>
@benhancock benhancock requested a review from a team as a code owner December 5, 2024 18:49
@benhancock benhancock changed the title fix: add completion support for ntl aliasin zsh fix: add completion support for ntl alias in zsh Dec 5, 2024
Copy link
Contributor

@NikAiyer NikAiyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some E2E tests are failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completions don't work with ntl alias on zsh
3 participants