Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor nested try/catch in ConnectionHandler #2778

Open
tippmar-nr opened this issue Sep 19, 2024 · 1 comment
Open

Refactor nested try/catch in ConnectionHandler #2778

tippmar-nr opened this issue Sep 19, 2024 · 1 comment

Comments

@tippmar-nr
Copy link
Member

Describe the story, please be clear on scope of the story.

There's a nested try/catch in SendDataOverWire() that can cause a misleading error message to be emitted indicating a serialization error that didn't really occur, because the nested try/catch throws the exception after logging it.

We need to refactor so that the call to _serializer.Serialize() is in a separate try/catch from the try/catch around wire.SendData(). This will eliminate the misleading message.

Acceptance Criteria

Error messages in SendDataOverWire() are not misleading

Estimates

Please provide initial t-shirt size
S

@workato-integration
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant