Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random password generation support for each upload #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jfut
Copy link

@jfut jfut commented Jun 2, 2019

Fixes: #54

Licence: AGPL3+ or any other compatible license

Description

This patch add random password generation support for each upload.
The generated password is printed at the beginning of the message body.
Also, if it disable the random password option, the fixed password is printed at the beginning of the message body.

Features

  • Add random password generation support for each upload.
  • The generated password is printed at the beginning of the message body.
  • If you disable the random password option, the fixed password is printed at the beginning of the message body.

Screenshots or screencasts

nextcloud-filelink-random-password-config
nextcloud-filelink-random-password-textmail
nextcloud-filelink-random-password-htmlmail

Tests

Test plan

Tested on

  • Windows/Thunderbird
  • Linux/Thunderbird
  • macOS/Thunderbird

Check list

  • Code is properly documented
  • Code is properly formatted
  • Commits have been squashed
  • Documentation (manuals or wiki) has been updated or is not required

Reviewers

The generated password is printed at the beginning of the message body.
Also, if it disable the random password option, the fixed password is
printed at the beginning of the message body.

Fixes: nextcloud#54

Signed-off-by: Jun Futagawa <jfut@integ.jp>
@jfut
Copy link
Author

jfut commented Jun 2, 2019

I added git -s option and force pushed.
Also, I tested Test addon file on Windows, Linux, and macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: New Password each time a File is sent / uploaded
1 participant