Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle checkboxes in view mode #451

Closed
stefan-niedermann opened this issue Aug 24, 2018 · 13 comments
Closed

Toggle checkboxes in view mode #451

stefan-niedermann opened this issue Aug 24, 2018 · 13 comments

Comments

@stefan-niedermann
Copy link
Member

After #422 it is now possible to implement support for toggling checkboxes in the view mode.

There is already commented code, that does not completely work.

@toxpal

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@sscholl

This comment has been minimized.

@tobru

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@tobru

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@tobru

This comment has been minimized.

@panki27

This comment has been minimized.

@stefan-niedermann

This comment has been minimized.

@stefan-niedermann
Copy link
Member Author

Another attempt to finally get this feature in: Everybody, please help test toggling checkboxes.

I attached a build of the branch #651 so you can easily install and test it:

nextcloud-notes-toggle-checkboxes.apk.zip

I think, there might be one or two bugs left caused by RxMarkdown, which we didn't workaround yet, just post it in #651 and i will try to take care of them.

stefan-niedermann added a commit that referenced this issue Dec 31, 2019
Print stacktrace on IndexOutOfBoundsException
@panki27
Copy link

panki27 commented Dec 31, 2019

I just installed the build and tested it quickly. It seems to work fine on Android 9!
Although, I had to uninstall the FDroid version first (I guess because this is a debug version?).

The 3x2 single note widget doesn't seem to work, it just shows "Note not found (Notiz nicht gefunden)". Used to work before :( This might be a completely unrelated issue, though.

The only difference to the web version is that it doesn't toggle the strike-through effect, but thats okay imo.

Thanks a lot, great work! 👍

@stefan-niedermann
Copy link
Member Author

Although, I had to uninstall the FDroid version first (I guess because this is a debug version?).

That's right, because the app signature is different for a released version.

Regarding the widget: i think it's unrelated, for me it works, but we can have a look after this has been merged
Please test as many scenarios as you can imagine (only checkboxes, mixed with headlines, items containing markdown, only one checkbox in the whole note, ...)

stefan-niedermann added a commit that referenced this issue Jan 2, 2020
wrong checkbox is associated with action
stefan-niedermann added a commit that referenced this issue Jan 2, 2020
Print stacktrace on IndexOutOfBoundsException
stefan-niedermann added a commit that referenced this issue Jan 2, 2020
wrong checkbox is associated with action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants