Too verbose logs when model not found

[leolivier]

Hi
For any PROPFIND and REPORT request (for CalDav/CardDav), I get some warnings like this:

{"reqId":"Ra8Dv8pIEVFztLxllaLX","level":2,"time":"2023-04-23T11:54:41+02:00","remoteAddr":"192.168.1.254","user":"olivier","app":"suspicious_login","method":"PROPFIND","url":"/remote.php/dav/principals/users/olivier/","message":"Could not predict suspiciousness: No models found","userAgent":"Thunderbird CalDAV/CardDAV","version":"26.0.1.1","data":{"app":"suspicious_login"}}

This is bloating the logs for nothing.
I tried $ occ suspiciouslogin:predict olivier 192.168.1.254 but got:

In ModelStore.php line 93:

  No models found

In QBMapper.php line 284:

  Did expect one result but found none when executing: query "SELECT * FROM `*PREFIX*suspicious_login_model` WHERE `address_type` = :dcValue1 ORDER BY `created_at` desc LIMIT 1";

suspiciouslogin:predict [--v6] [--] <uid> <ip> [<model>]

in my config.php, the trusted_proxies is defined to

  'trusted_proxies' =>
  array (
    0 => '192.168.1.254',
    1 => '192.168.1.8',
  ),

the proxy settings in Apache is:

  ProxyPass "/.well-known/carddav" "${NCInternalURI}/remote.php/dav"
  ProxyPass "/.well-known/caldav" "${NCInternalURI}/remote.php/dav"
  ProxyPass "/.well-known/webfinger" "${NCInternalURI}/index.php/.well-known/webfinger"
  ProxyPass "/.well-known/nodeinfo" "${NCInternalURI}/index.php/.well-known/nodeinfo"

I think this configuration is ok.
So, is there a way to remove these unnecessary logs?

[joshtrichards]

Looks like we are kinda-sorta double logging it too (depending on local loglevel:

suspicious_login/lib/Service/ModelStore.php

Lines 91 to 94 in 6079156

	} catch (DoesNotExistException $e) {
	$this->logger->debug("No models found. Can't load latest");
	throw new ServiceException("No models found", 0, $e);
	}

The issue is we're overloading the use of ServiceException probably a bit I guess:

suspicious_login/lib/Service/LoginClassifier.php

Lines 116 to 120 in 6079156

	} catch (ServiceException $ex) {
	$this->logger->warning("Could not predict suspiciousness: " . $ex->getMessage());
	// This most likely means there is no trained model yet, so we return early here
	return;
	}

suspicious_login/lib/Service/EstimatorService.php

Lines 55 to 68 in 6079156

	public function predict(string $uid, string $ip, AClassificationStrategy $strategy, int $modelId = null): bool {
	try {
	if ($modelId === null) {
	$this->logger->debug("loading latest model");
	$estimator = $this->modelStore->loadLatest($strategy);
	} else {
	$this->logger->debug("loading model $modelId");
	$estimator = $this->modelStore->load($modelId);
	}
	} catch (RuntimeException $e) {
	throw new ServiceException("Could not load model $modelId to classify UID $uid and IP $ip: " . $e->getMessage(), $e->getCode(), $e);
	}