Unable to edit photos; redirected back to the file list (NC 29 & 30) #2323

RyoKub · 2024-04-30T08:48:42Z

Description

When accessing the Photos app at http://[nextcloud]/apps/photos/ and clicking on the viewer to view images, the interface allows for normal interaction. However, attempting to edit an image by clicking the pencil icon results in being redirected back to the file list screen instead of opening the editing interface.

Error Message

Console in Browser : [Deprecation] Listener added for a 'DOMNodeInserted' mutation event. This event type is deprecated, and will be removed from this browser very soon. Usage of this event listener will cause performance issues today, and represents a large risk of future site breakage. Consider using MutationObserver instead. See https://chromestatus.com/feature/5083947249172480 for more information.

This issue occurs consistently across different browsers including Edge and Chrome on Windows, and Safari on iPad.

Steps to Reproduce

Open the Nextcloud Photos app at http://[nextcloud]/apps/photos/.
Click on any photo to view it.
Attempt to edit the photo by clicking the pencil icon.
Observe that instead of transitioning to the edit mode, the interface redirects back to the file list.

Expected behavior

The expected behavior is to transition to the photo editing interface as was the case in previous version 28.0.3.

Actual behavior

Clicking the edit icon redirects back to the photo file list, and a deprecation warning is logged in the console.

Environment

Nextcloud version: 29.0.0
Photos app version: 2.5.0
Operating system: Windows and iOS
Browser: Edge, Chrome, Safari

Additional context

This issue prevents any editing functionality within the Photos app, which was functional in the previous version 28.0.3. The same behavior is observed across multiple platforms and browsers indicating a possible issue with the app's handling of deprecated browser features.

dennisheitmann · 2024-05-06T14:22:39Z

Same here. Nextcloud 29.0.0.19 with photos 2.5.0. Tested with Chrome and Firefox on Linux.

After not editing was not working, also display of photos does not work anymore until reload of page:

ralfi · 2024-05-13T09:50:11Z

confirm, memories works

bobobo-git · 2024-05-26T10:03:49Z

confirm it.
also look at https://help.nextcloud.com/t/editing-in-images-doesnt-work/189508

😀

bobobo-git · 2024-05-29T12:19:38Z

the errormessage from above is also applied in NC 27.5.1 but there the fotoapp reacts correct

bobobo-git · 2024-05-29T13:36:27Z

i took the viewer app from a nextcloud 27 , edited the info.xml in the appinfo-folder (max-version="29")
and and overwrote the existing viewer app

and then (after an updatemessage) it worked ok.

so it seam to be the viewer app
(it isn't loaded in webpack when using the nc 29 version)

maybe it is time to contact the author of the viewer app
author mail="skjnldsv@protonmail.com" John Molakvoæ from the info.xml

the content of folder js in the app looks strange
no js files but mjs files ...

bobobo-git · 2024-05-29T13:45:22Z

i replaced all in js folder with the content of the js folder from the nc27 version

after an update message everything runs ok in nc 29
BUT the editor for text / md wont work anymore.

in a fresh installation nc 29.0.1 , all apps deactivated, a click on a jpg shows it but will not load the editor if clicked on the pencil.

bobobo-git · 2024-05-30T16:22:50Z

the image editor (*) fails to load in nc 29.

implementatin of filerobot image editor https://scaleflex.github.io/filerobot-image-editor/

read here https://nextcloud.com/blog/how-we-got-to-the-new-nextcloud-photos/

joshtrichards · 2024-05-31T15:33:44Z

Reproduced. Editing is provided by Viewer not the Photos app. Transferred to that repo.

alexanderdd · 2024-08-13T08:20:50Z

Still broken in NC 30.0.0 beta 5 (tested on c.nc.com)

Weird also: after unsuccessfully trying to edit and getting thrown back to files list, and clicking an image again, you see the error "no plugin avialable to view this file type" (German "Es ist kein Plugin zum Anzeigen dieses Dateityps verfügbar")

thlehmann-ionos · 2024-09-10T15:12:04Z

Without more in-depth investigation: the problem seems to be related to the bundling/module-loading.

The error is not reproducible in a dev environment with debug => true. The difference here is the script loading does not add a cache-buster to the URL in dev mode, while in production mode, it's added.

In production one can observe that viewer-main.mjs is loaded a second time without a cache buster when clicking the pencil icon.

I assume that the viewer code loads and executes a second time, this time with no handlers being registered through registerHandler() (because this already happend). When stepping through the code one can see that openFileInfo() upon pencil icon click failed due to registeredHandlers being empty. Yet, when breaking in registerHandler() on page load we observe handlers being registered.

Vite does not seem to be aware of the added cachebuster when lazy-importingfilerobot-image-editor in ImageEditort.vue's mounted()

(Edits: clarifications, formatting)

thlehmann-ionos · 2024-09-10T15:13:41Z

I'm not familiar enough with the setup and Vite's bundling internals, and I am happy to attempt fixing it if someone could give me some hints here.

dolorosus · 2024-09-29T09:39:53Z

At the moment it does not look like this error will be fixed. I therefore suggest removing the pencil icon (edit).

Infamousbugg · 2024-10-08T01:02:24Z

This is resolved for me on Nextcloud 30.0.1 RC1.

thlehmann-ionos · 2024-10-10T17:16:35Z

Still reproducible with Nextcloud tag v30.0.0 and Viewer tag v30.0.0,'debug' => false (so that a cache-buster parameter is appended to resources)

ivnmad · 2024-10-10T20:27:57Z

This is resolved for me on Nextcloud 3.0.1 RC1.

I can confirm the issue seems to be solved with 3.0.1 RC1

ostasevych · 2024-10-13T21:26:50Z

This is resolved for me on Nextcloud 3.0.1 RC1.

I can confirm the issue seems to be solved with 3.0.1 RC1

Hi! How to get 3.0.1 RC1 version and backport to 29.0.x?
Are any other alternatives?

ivnmad · 2024-10-14T07:43:07Z

This is resolved for me on Nextcloud 3.0.1 RC1.

I can confirm the issue seems to be solved with 3.0.1 RC1

Hi! How to get 3.0.1 RC1 version and backport to 29.0.x? Are any other alternatives?

Hi, Nextcloud Hub 9 (30.0.1 RC2) has been released in the meantime.
You can find it on the "beta" channel, but I would presume a version that includes the fix [30.0.2 or next] should make it to the "stable" channel soon.

In case you want to get it from the "beta" channel, you can select it from "Administration settings".
After installing the update, you can then "revert" back to "stable" if you want the next update to come from that channel, or you can stay on the beta channel, if you like testing new versions:

ostasevych · 2024-10-14T08:26:49Z

i took the viewer app from a nextcloud 27 , edited the info.xml in the appinfo-folder (max-version="29") and and overwrote the existing viewer app

and then (after an updatemessage) it worked ok.

so it seam to be the viewer app (it isn't loaded in webpack when using the nc 29 version)

maybe it is time to contact the author of the viewer app author mail="skjnldsv@protonmail.com" John Molakvoæ from the info.xml

the content of folder js in the app looks strange no js files but mjs files ...

UPD: Yes. I have overwritten files from NC 28.0.11 and confirm, that it works, moreover the text docs are opening as well. Rollback to viewer v.2.3.0 can be feasible here as a temporary solution.

ostasevych · 2024-10-14T08:47:52Z

This is resolved for me on Nextcloud 3.0.1 RC1.

I can confirm the issue seems to be solved with 3.0.1 RC1

Hi! How to get 3.0.1 RC1 version and backport to 29.0.x? Are any other alternatives?

Hi, Nextcloud Hub 9 (30.0.1 RC2) has been released in the meantime. You can find it on the "beta" channel, but I would presume a version that includes the fix [30.0.2 or next] should make it to the "stable" channel soon.

In case you want to get it from the "beta" channel, you can select it from "Administration settings". After installing the update, you can then "revert" back to "stable" if you want the next update to come from that channel, or you can stay on the beta channel, if you like testing new versions:

Can I extract viewer app from NC 30.0.2 and will it be working in NC 29.0.8?

thlehmann-ionos · 2024-10-14T08:56:16Z

Still reproducible with Nextcloud tag v30.0.0 and Viewer tag v30.0.0,'debug' => false (so that a cache-buster parameter is appended to resources)

It's no longer reproducible on viewer tag v30.0.1rc2. 👍

ostasevych · 2024-10-14T09:03:01Z

Still reproducible with Nextcloud tag v30.0.0 and Viewer tag v30.0.0,'debug' => false (so that a cache-buster parameter is appended to resources)

It's no longer reproducible on viewer tag v30.0.1rc2. 👍

What is the version of the viewer app? Is it 3.0.0 according to info.xml file?

thlehmann-ionos · 2024-10-14T09:18:33Z

Still reproducible with Nextcloud tag v30.0.0 and Viewer tag v30.0.0,'debug' => false (so that a cache-buster parameter is appended to resources)

It's no longer reproducible on viewer tag v30.0.1rc2. 👍

What is the version of the viewer app? Is it 3.0.0 according to info.xml file?

The version from info.xml is 3.0.0.

Git revision: 6d3ae93f.

ostasevych · 2024-10-14T09:22:00Z

Still reproducible with Nextcloud tag v30.0.0 and Viewer tag v30.0.0,'debug' => false (so that a cache-buster parameter is appended to resources)

It's no longer reproducible on viewer tag v30.0.1rc2. 👍

What is the version of the viewer app? Is it 3.0.0 according to info.xml file?

The version from info.xml is 3.0.0.

Git revision: 6d3ae93f.

I tried to use it with NC29.0.8, changed the info.xml file by setting version=2.3.0 and min-version=29 to skip the update prompt. That didn't work.

randall11GB · 2024-10-19T06:21:35Z

same issue. installed new nextcloud using linuxserver.io v30 hub9 -- same issue exists on new install.

ivnmad · 2024-10-19T07:04:49Z

same issue. installed new nextcloud using linuxserver.io v30 hub9 -- same issue exists on new install.

@randall11GB upgrade to 30.0.1 and the issue will be solved.

randall11GB · 2024-10-19T08:01:53Z

Yes just upgraded. Resolved. Much appreciated. Sent from Proton Mail Android

…

-------- Original Message --------

On 10/19/24 10:35 AM, Ivan V. wrote: > same issue. installed new nextcloud using linuxserver.io v30 hub9 -- same issue exists on new install. ***@***.***(https://github.com/randall11GB) upgrade to 30.0.1 and the issue will be solve. — Reply to this email directly, [view it on GitHub](#2323 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/A4A32BW5QTCTHRQW3YW7ETDZ4IAC3AVCNFSM6AAAAABITA2E2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTGYZTANZQG4). You are receiving this because you were mentioned.Message ID: ***@***.***>

ostasevych · 2024-10-19T08:23:51Z

same issue. installed new nextcloud using linuxserver.io v30 hub9 -- same issue exists on new install.

@randall11GB upgrade to 30.0.1 and the issue will be solve.

Is that possible to fix it somehow at 29.0.x?

randall11GB · 2024-10-19T08:30:40Z

30.0.1 definitely resolved issue . From original 30.0.0 . But dont know about 29.x resolution. I am sure other friends here can help you. Best

ralfi · 2024-10-21T06:19:18Z

Yes, issue resolved with 30.0.1

artonge · 2024-10-23T16:07:42Z

Should be fixed in 29.0.9 and 28.0.12

RyoKub added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Apr 30, 2024

RyoKub changed the title ~~Title: Unable to edit photos; redirected back to the file list~~ Nextcloud:29.0.0 Unable to edit photos; redirected back to the file list May 1, 2024

This comment has been minimized.

Sign in to view

joshtrichards added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels May 31, 2024

joshtrichards transferred this issue from nextcloud/photos May 31, 2024

ernolf mentioned this issue Jun 10, 2024

[Bug]: Editing an image does not work nextcloud/server#45484

Closed

8 tasks

skjnldsv self-assigned this Jul 5, 2024

skjnldsv added the high High priority label Jul 5, 2024

skjnldsv mentioned this issue Jul 9, 2024

Edit via fullscreen broken nextcloud/photos#2540

Closed

alexanderdd added the regression Regression of a previous working feature label Jul 15, 2024

alexanderdd changed the title ~~Nextcloud:29.0.0 Unable to edit photos; redirected back to the file list~~ Unable to edit photos; redirected back to the file list (NC 29 & 30) Aug 13, 2024

joshtrichards mentioned this issue Sep 9, 2024

After upgrade to 2.5.0 wrong picture shown in Firefox 115.13.0esr #2487

Open

This comment has been minimized.

Sign in to view

szaimen mentioned this issue Sep 30, 2024

update to Nextcloud 30 nextcloud/all-in-one#5249

Open

36 tasks

sorbaugh assigned artonge Oct 1, 2024

artonge mentioned this issue Oct 2, 2024

[stable29] fix: Make loading the viewer an init script #2490

Merged

3 tasks

joshtrichards added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Oct 6, 2024

joshtrichards linked a pull request Oct 6, 2024 that will close this issue

[stable29] fix: Make loading the viewer an init script #2490

Merged

3 tasks

joshtrichards pinned this issue Oct 6, 2024

artonge closed this as completed Oct 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unable to edit photos; redirected back to the file list (NC 29 & 30) #2323

Unable to edit photos; redirected back to the file list (NC 29 & 30) #2323

RyoKub commented Apr 30, 2024 •

edited

Loading

dennisheitmann commented May 6, 2024 •

edited

Loading

ralfi commented May 13, 2024

This comment has been minimized.

bobobo-git commented May 26, 2024

bobobo-git commented May 29, 2024

bobobo-git commented May 29, 2024 •

edited

Loading

bobobo-git commented May 29, 2024 •

edited

Loading

bobobo-git commented May 30, 2024 •

edited

Loading

joshtrichards commented May 31, 2024

alexanderdd commented Aug 13, 2024

thlehmann-ionos commented Sep 10, 2024 •

edited

Loading

thlehmann-ionos commented Sep 10, 2024

This comment has been minimized.

dolorosus commented Sep 29, 2024

Infamousbugg commented Oct 8, 2024 •

edited

Loading

thlehmann-ionos commented Oct 10, 2024

ivnmad commented Oct 10, 2024

ostasevych commented Oct 13, 2024 •

edited

Loading

ivnmad commented Oct 14, 2024 •

edited

Loading

ostasevych commented Oct 14, 2024 •

edited

Loading

ostasevych commented Oct 14, 2024 •

edited

Loading

thlehmann-ionos commented Oct 14, 2024

ostasevych commented Oct 14, 2024

thlehmann-ionos commented Oct 14, 2024

ostasevych commented Oct 14, 2024 •

edited

Loading

randall11GB commented Oct 19, 2024

ivnmad commented Oct 19, 2024 •

edited

Loading

randall11GB commented Oct 19, 2024 via email

ostasevych commented Oct 19, 2024

randall11GB commented Oct 19, 2024

ralfi commented Oct 21, 2024

artonge commented Oct 23, 2024 •

edited

Loading

Unable to edit photos; redirected back to the file list (NC 29 & 30) #2323

Unable to edit photos; redirected back to the file list (NC 29 & 30) #2323

Comments

RyoKub commented Apr 30, 2024 • edited Loading

Description

Error Message

Steps to Reproduce

Expected behavior

Actual behavior

Environment

Additional context

dennisheitmann commented May 6, 2024 • edited Loading

ralfi commented May 13, 2024

This comment has been minimized.

bobobo-git commented May 26, 2024

bobobo-git commented May 29, 2024

bobobo-git commented May 29, 2024 • edited Loading

bobobo-git commented May 29, 2024 • edited Loading

bobobo-git commented May 30, 2024 • edited Loading

joshtrichards commented May 31, 2024

alexanderdd commented Aug 13, 2024

thlehmann-ionos commented Sep 10, 2024 • edited Loading

thlehmann-ionos commented Sep 10, 2024

This comment has been minimized.

dolorosus commented Sep 29, 2024

Infamousbugg commented Oct 8, 2024 • edited Loading

thlehmann-ionos commented Oct 10, 2024

ivnmad commented Oct 10, 2024

ostasevych commented Oct 13, 2024 • edited Loading

ivnmad commented Oct 14, 2024 • edited Loading

ostasevych commented Oct 14, 2024 • edited Loading

ostasevych commented Oct 14, 2024 • edited Loading

thlehmann-ionos commented Oct 14, 2024

ostasevych commented Oct 14, 2024

thlehmann-ionos commented Oct 14, 2024

ostasevych commented Oct 14, 2024 • edited Loading

randall11GB commented Oct 19, 2024

ivnmad commented Oct 19, 2024 • edited Loading

randall11GB commented Oct 19, 2024 via email

ostasevych commented Oct 19, 2024

randall11GB commented Oct 19, 2024

ralfi commented Oct 21, 2024

artonge commented Oct 23, 2024 • edited Loading

RyoKub commented Apr 30, 2024 •

edited

Loading

dennisheitmann commented May 6, 2024 •

edited

Loading

bobobo-git commented May 29, 2024 •

edited

Loading

bobobo-git commented May 29, 2024 •

edited

Loading

bobobo-git commented May 30, 2024 •

edited

Loading

thlehmann-ionos commented Sep 10, 2024 •

edited

Loading

Infamousbugg commented Oct 8, 2024 •

edited

Loading

ostasevych commented Oct 13, 2024 •

edited

Loading

ivnmad commented Oct 14, 2024 •

edited

Loading

ostasevych commented Oct 14, 2024 •

edited

Loading

ostasevych commented Oct 14, 2024 •

edited

Loading

ostasevych commented Oct 14, 2024 •

edited

Loading

ivnmad commented Oct 19, 2024 •

edited

Loading

artonge commented Oct 23, 2024 •

edited

Loading