-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module proposal: hello-channels #367
Comments
I think this is a great training module plan. |
hello-channels1 DebuggingObjective: Know how to view the contents of a channel 1.1. Use
|
This is perfect. I really like the progression that you've designed here. I was trying to explain this concept to someone fresh out of hello-gatk using our existing training materials (in Advanced) and I quickly ran into the issue of needing to explain things that hadn't been covered yet. |
After discussion with @maxulysse, we think we can make it better.
Then we could have another module afterwards which includes more advanced concepts like |
hello-channels1 CollectObjective: Understand how to collect a channel into 1 item. 1.1. Add jointgenotyping processAs hello-gatk. Run and see every VCF is being ran separately. 1.1. Use
|
I love the overall plan for Hello-Channels but I think I'd like to keep the joint-genotyping as part of the Hello-GATK module, because it makes for a very satisfying example as it stands now. However I could be convinced to change my mind because as I type I realize this could be an opportunity to simplify GATK further (the GVCF stuff is a bit of a curve ball). We could change Hello-GATK to emit regular VCFs and have that module show a purely linear example (and also keep the groovy magic mostly out of the 'first bioinfx example' for simplicity). And that way people are already a bit further down their Nextflow journey when they hit the more interesting plumbing options. Ok I've gone and convinced myself this is the way to go. Question: should this new Hello-Channels module come before or after the Config/Modules/nf-test ones? (note that I want to move hello-config to before hello-modules) |
…les (#391) Reorder training modules and add stubs to expand the series, improve instructions and add explanations throughout, update GATK flowcharts, improve flow and improve formatting. Notable changes: * In Hello-World, start by looking at the code before running it * Convert the splitText to splitCsv in Hello-World * Add stub for new Hello-Containers module (Ken) * Rename Hello-GATK to Hello-Science * Simplify Hello-Science by moving GVCF and joint genotyping out to new Hello-Channels module based on Adam's proposal in #367 * Improve flow of joint genotyping in Hello-Channels --------- Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io> Co-authored-by: Ken Brewer <kenibrewer@users.noreply.github.com>
I implemented part of this in #408 with the following caveats:
|
hello-channels
An additional module that would fit between hello-gatk and hello-modules.
Aims:
Proposal:
Subject to change, this part might need further discussion.
From the hello-gatk pipeline, add the following features stepwise
splitCsv
)map
)groupTuple
)Key targets:
view
for debuggingmap
for manipulating channel contentscollectFile
,groupTuple
,join
for demonstrating how channels can be manipulated with built in methods.To do:
Related issues
#361
#359
The text was updated successfully, but these errors were encountered: